Feature/pretty json by netbe · Pull Request #132 · netbe/Babelish

netbe · 2020-06-08T21:11:24Z

Superseeds #109. rebased with master

d7e7678

houndci-bot · 2020-06-08T21:11:30Z

test/babelish/test_csv2json.rb

+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, 
+    { "English" => "en" }, 
+    output_basename: "output", 


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2020-06-08T21:11:31Z

test/babelish/test_csv2json.rb

+
+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, 
+    { "English" => "en" }, 


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2020-06-08T21:11:31Z

test/babelish/test_csv2json.rb

+    given_json_filename = "output.json"
+
+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, 


Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2020-06-08T21:11:31Z

test/babelish/test_csv2json.rb

+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, 
+    { "English" => "en" }, 
+    output_basename: "output", 


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2020-06-08T21:11:31Z

test/babelish/test_csv2json.rb

+
+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, 
+    { "English" => "en" }, 


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2020-06-08T21:11:31Z

test/babelish/test_csv2json.rb

+    given_json_filename = "output.json"
+
+    expected_json = File.read("test/data/" + expected_json_filename)
+    converter = Babelish::CSV2JSON.new(csv_file, 


Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2020-06-08T21:11:31Z

lib/babelish/version.rb

@@ -1,3 +1,3 @@
 module Babelish
-  VERSION = "0.6.5"
+  VERSION = "0.6.4"


Style/MutableConstant: Freeze mutable objects assigned to constants.

houndci-bot · 2020-06-08T21:11:32Z

lib/babelish/commandline.rb

    method_option :ignore_lang_path, :type => :boolean, :aliases => "-I", :lazy_default => false, :desc => "Ignore the path component of langs"
    method_option :fetch, :type => :boolean, :desc => "Download file from Google Drive"
    method_option :sheet, :type => :numeric, :desc => "Index of worksheet to download. First index is 0"
+    method_option :pretty_json, :type => :boolean, aliases: "-p", desc: "Prettify your json output files"


Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Metrics/LineLength: Line is too long. [105/80]

houndci-bot · 2020-06-08T21:21:34Z

test/babelish/test_strings2csv.rb

-      :filenames => filenames })
+      csv_filename: csv_filename,
+      headers: headers,
+      filenames: filenames })


Layout/MultilineHashBraceLayout: Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.

houndci-bot · 2020-06-08T21:21:34Z

test/babelish/test_strings2csv.rb

-      :csv_filename => csv_filename,
-      :headers => headers,
-      :filenames => filenames })
+      csv_filename: csv_filename,


Layout/IndentHash: Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.

houndci-bot · 2020-06-08T21:21:34Z

test/babelish/test_strings2csv.rb

    strings = {filename => {"ERROR_HANDLER_WARNING_DISMISS" => "OK", "ANOTHER_STRING" => "hello"}}

-    converter = Babelish::Strings2CSV.new(:headers => %w{variables english}, :filenames => [filename])
+    converter = Babelish::Strings2CSV.new(headers: %w{variables english}, filenames: [filename])


Metrics/LineLength: Line is too long. [96/80]

houndci-bot · 2020-06-08T21:21:34Z

test/babelish/test_strings2csv.rb


  def test_dotstrings_to_csv
-    converter = Babelish::Strings2CSV.new(:filenames => ["test/data/test_data.strings"])
+    converter = Babelish::Strings2CSV.new(filenames: ["test/data/test_data.strings"])


Metrics/LineLength: Line is too long. [85/80]

houndci-bot · 2020-06-08T21:21:34Z

test/babelish/test_php2csv.rb

-      :filenames => filenames })
+      csv_filename: csv_filename,
+      headers: headers,
+      filenames: filenames })


Layout/MultilineHashBraceLayout: Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.

houndci-bot · 2020-06-08T21:21:36Z

test/babelish/test_csv2strings.rb

    converter = Babelish::CSV2Strings.new(csv_file,
    {'English' => [:en], "French" => "fr", "German" => "de", "Spanish" => "es"},
-    :default_lang => "variables")
+    default_lang: "variables")


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.

houndci-bot · 2020-06-08T21:21:36Z

test/babelish/test_csv2strings.rb

    converter = Babelish::CSV2Strings.new(csv_file,
    {'English' => [:en], "French" => "fr", "German" => "de", "Spanish" => "es"},
-    :default_lang => "English")
+    default_lang: "English")


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.

houndci-bot · 2020-06-08T21:21:36Z

test/babelish/test_csv2strings.rb

    {'English' => [:en]},
-    :output_basename => 'myApp',
-    :ignore_lang_path => true)
+    output_basename: 'myApp',


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2020-06-08T21:21:36Z

test/babelish/test_csv2php.rb

    {'English' => "en"},
-    :output_basename => 'myApp',
-    :ignore_lang_path => true)
+    output_basename: 'myApp',


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2020-06-08T21:21:36Z

test/babelish/test_csv2json.rb

    {'English' => "en"},
-    :output_basename => 'myfile',
-    :ignore_lang_path => true)
+    output_basename: 'myfile',


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

netbe and others added 8 commits June 8, 2020 22:42

Revert "Version bumped"

dbd92d6

d7e7678

Extend configuration file with pretty_json parameter

5e9087c

Update .babelish.sample

b89754e

Add alias for pretty_json option

5d7b16b

Refactor csv2base

28d320b

Remove default parameter from commandline.rb

c22ce9f

Apply fixes according to automatic code review

9598e4e

Fix formatting in test_csv2json.rb

fe4a473

houndci-bot reviewed Jun 8, 2020

View reviewed changes

Fixes rule about Ruby19 hash syntax

9fa208c

houndci-bot reviewed Jun 8, 2020

View reviewed changes

Comments

Conversation

netbe commented Jun 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants