Add sun event scheduling (e.g. RunAtSunrise() )#1358
Open
duanemck wants to merge 1 commit intonet-daemon:mainfrom
Open
Add sun event scheduling (e.g. RunAtSunrise() )#1358duanemck wants to merge 1 commit intonet-daemon:mainfrom
RunAtSunrise() )#1358duanemck wants to merge 1 commit intonet-daemon:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
In home automation it is often useful to trigger automations based off sun events such as sunrise or sunset. This feature extends the scheduling extension and wraps the
SolarCalculatorNuget library to add a service with methods such asRunAtSunset(). I've only added sunrise, sunset, dusk and dawn though the underlying library supports other events.As the SolarCalculator requires latitude, longitude and a Solar calculator to work, the new methods could not be added as extensions methods on IScheduler, so instead, a new service was introduced.
Type of change
Additional information
Checklist
If user exposed functionality or configuration are added/changed: