Conversation
…-ipfs-http-client Changes: * GH workflow updates (Java 21, use mvnw) * GH dependabot enabled for Maven as well * apply same .mvn/maven.config (but no checksum as there are no deps) * use wrapper + enable sha256 distro checksum * reformat same way as ipfs-http-client * update to Junit 6.0.2 (drop hamcrest; is unused) * no Java source code changes (sans reformat) Dependency uses SNAPSHOT of multibase (will fail on CI).
Contributor
Author
|
So what now (re SNAPSHOT)? We gonna perform tidy-ups and releases in lockstep? Or any other idea? Before doing that, we may want to lay down names? Are module names mentioned in PR https://github.com/ipfs-shipyard/java-ipfs-http-client/pull/269/changes okay? |
Member
|
Lockstep is fine by me. And those module names look fine. |
Contributor
Author
|
Right. There is another problem: The So I removed those, but that will cause breakage |
Contributor
Author
|
Discuss it here multiformats/java-multibase#48 |
Contributor
Author
|
Just as a demo, pushed more: snapshots are now shared via IPFS. Repository (for demo purposes) is: |
Contributor
Author
|
Ok, changes pushed:
|
Contributor
Author
|
If merging this, please squash merge (or ping me to squash beforehand) |
ianopolous
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply same set of changes as to https://github.com/ipfs-shipyard/java-ipfs-http-client
Changes:
Dependency uses SNAPSHOT of multibase (will fail on CI).