ThreeSpecies_Quiescent: set initial_population parameter as start value of population#471
Open
fubari wants to merge 1 commit intomtiller:masterfrom
Open
ThreeSpecies_Quiescent: set initial_population parameter as start value of population#471fubari wants to merge 1 commit intomtiller:masterfrom
fubari wants to merge 1 commit intomtiller:masterfrom
Conversation
The population variable is protected and setting the start value only works when using the FixedPopulation initialization. When using InitializationOptions.SteadyState, the start value is not adjusted (as in the ThreeSpecies_Quiescent example, which does not find the correct solution for me using OpenModelica). With this change, all examples work for me.
fubari
changed the title
fubari
changed the title
fubari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ThreeSpecies_Quiescentexample seems to be broken usingOpenModelica v1.24.0-dev-164-g537f41ed82, probably due to the changes to theProtectedsection of models in Modelica, see #453. This PR suggests a solution by adjusting the start value.The population variable is protected and setting the start value only works when using the
FixedPopulationinitialization, then it is set using:ModelicaBook/ModelicaByExample/Components/LotkaVolterra/Components/RegionalPopulation.mo
Lines 18 to 19 in b07a59e
When using
InitializationOptions.SteadyState, the start value is not adjusted and the trivial solution is found instead of the non-zero solution.Only the derivative is adjusted:
ModelicaBook/ModelicaByExample/Components/LotkaVolterra/Components/RegionalPopulation.mo
Lines 20 to 21 in b07a59e
And for the start guess, the following line is still used:
ModelicaBook/ModelicaByExample/Components/LotkaVolterra/Components/RegionalPopulation.mo
Line 16 in b07a59e
With the following change, all examples seem to work correctly for me: