Fix a unit and update a term to be vectorized in ArrayEquations.HeatTransfer#470
Open
adrian-nilsson-fcc wants to merge 2 commits intomtiller:masterfrom
Open
Fix a unit and update a term to be vectorized in ArrayEquations.HeatTransfer#470adrian-nilsson-fcc wants to merge 2 commits intomtiller:masterfrom
adrian-nilsson-fcc wants to merge 2 commits intomtiller:masterfrom
Conversation
The example gave a "Translation Error" since to the variable `i` is never declared. It seems like the first term was simply not vectorized when the example was updated in a87d4af
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two bugs in the
HeatTransferexamples in ch. 3.Wrong unit for
ConvectionCoefficientFixes #454
Missing vectorization
The first term of the derivative that uses vector notation has two problems:
i, which is never declared in this exampleThe solution presented in this PR is straightforward: Replace
with