Make search icon a button #3958
Merged
+74
−192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
reviewed
Feb 10, 2026
Collaborator
flodolo
left a comment
flodolo
left a comment
There was a problem hiding this comment.
I don't think this is a good solution:
- It's hard to discover.
- The lens icon has different behaviors, even within this page (in the dropdown for the locale it doesn't do anything).
- I find it counterintuitive to have a button on the left of content in LTR layout.
If the concern is about space, this doesn't feel crowded? We can shorten the checkbox labels if necessary.
We can also ask in Matrix for feedback from localizers.
mathjazz
force-pushed
the
3952-search-page-button
branch
from
9903397 to
9bd77fd
Compare
Collaborator
Author
|
The following changes are unrelated to this PR. Happy to push them to a separate PR if needed: |
flodolo
approved these changes
Feb 11, 2026
Collaborator
flodolo
left a comment
flodolo
left a comment
There was a problem hiding this comment.
Seems to work fine, and I can't spot regressions in the rest of the pages using buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3952.