Fix #3417: Add data migration to create project_managers group #3948

first-afk · 2026-02-05T22:50:43Z

Creates a data migration file that checks if project_managers group exists; if not, it creates it. Checks if can_mange_project permission exists; if not, the migration file creates it. Finally, grant project_managers can_mange_project permission.

codecov-commenter · 2026-02-05T22:56:58Z

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.58%. Comparing base (d4f98e0) to head (91b9220).
⚠️ Report is 7 commits behind head on main.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mathjazz

Great work, thank you! 🥳

mathjazz · 2026-02-06T09:06:44Z

Fix #3417.

Note that adding Fixed #ISSUE_NUMBER links the PR to the said issue and fixes it automatically after the PR is merged.

mathjazz

Figured there are a few ways to improve this.

Could you please check these suggestions?

mathjazz · 2026-02-06T09:26:24Z

pontoon/base/migrations/0106_create_project_managers_group.py

+    # 2. Get or Create the 'project_managers' group
+    group, created = Group.objects.get_or_create(name="project_managers")
+    if created:
+        print("Created 'project_managers' group.")


Please use log.info() instead of print().

mathjazz · 2026-02-06T09:33:01Z

pontoon/base/migrations/0106_create_project_managers_group.py

+    # 3. Ensure the 'can_manage_project' permission exists
+    # We find the ContentType ID for the Project model
+    project_content_type = ContentType.objects.get_for_model(Project)
+
+    permission, perm_created = Permission.objects.get_or_create(
+        codename="can_manage_project",
+        content_type=project_content_type,
+        defaults={"name": "Can manage project"},
+    )


Using ContentType.objects.get_for_model() in Django migrations is not inherently "safe", because it relies on the live application state rather than the historical migration state.

Also, we should not create the permission in the migration, since it's already created in the model.

Suggested change

# 3. Ensure the 'can_manage_project' permission exists

# We find the ContentType ID for the Project model

project_content_type = ContentType.objects.get_for_model(Project)

permission, perm_created = Permission.objects.get_or_create(

codename="can_manage_project",

content_type=project_content_type,

defaults={"name": "Can manage project"},

)

# 3. Fetch the permission declared on Project.Meta.permissions

project_content_type = ContentType.objects.get(app_label="base", model="project")

permission = Permission.objects.get(

codename="can_manage_project",

content_type=project_content_type,

)

Please use the comment and permission definition as suggested above.

mathjazz · 2026-02-06T09:35:40Z

pontoon/base/migrations/0106_create_project_managers_group.py

+    ]
+
+    operations = [
+        migrations.RunPython(create_pm_group, remove_pm_group),


I would drop remove_pm_group(), because it seems risky. It deletes the whole group, even if it existed before this migration.

Suggested change

migrations.RunPython(create_pm_group, remove_pm_group),

migrations.RunPython(create_pm_group, reverse_code=migrations.RunPython.noop),

Co-authored-by: Matjaž Horvat <matjaz.horvat@gmail.com>

mathjazz

Thanks for the update! Please check again suggested changes in the unresolved comment.

Please also make sure tests don't fail.

mathjazz · 2026-02-06T22:24:54Z

pontoon/base/migrations/0106_create_project_managers_group.py

+    # 3. Ensure the 'can_manage_project' permission exists
+    # We find the ContentType ID for the Project model
+    project_content_type = ContentType.objects.get_for_model(Project)
+
+    permission, perm_created = Permission.objects.get_or_create(
+        codename="can_manage_project",
+        content_type=project_content_type,
+        defaults={"name": "Can manage project"},
+    )


Please use the comment and permission definition as suggested above.

first-afk · 2026-02-06T22:58:56Z

Hello @mathjazz I apologize for the delayed reply to the comments. I fixed the code with the suggestions you made, but I'm having a slight issue figuring out why I'm running into an error with the bot. I'm currently working on it now

first-afk · 2026-02-07T00:13:58Z

The error from the tests originates from the get() method. The method tries to fetch permissions that Django has not created yet. I added a line to trigger a population signal, but that crashed as well. After running 3 other tests and them failing due to missing tables in the migration, using get_or_create() will allow creating a specific contentType without triggering a registry scan and hitting a domino dependency issue.

flodolo · 2026-02-07T16:45:22Z

pontoon/base/migrations/0106_create_project_managers_group.py

+    Permission = apps.get_model("auth", "Permission")
+    ContentType = apps.get_model("contenttypes", "ContentType")
+
+    emit_post_migrate_signal(2, False, "default")


Can this be the cause of the failures?

What is the purpose of this line? It should be removed.

mathjazz · 2026-02-10T08:24:51Z

pontoon/base/migrations/0106_create_project_managers_group.py

+    Permission = apps.get_model("auth", "Permission")
+    ContentType = apps.get_model("contenttypes", "ContentType")
+
+    emit_post_migrate_signal(2, False, "default")


What is the purpose of this line? It should be removed.

mathjazz · 2026-02-10T08:25:50Z

pontoon/base/migrations/0106_create_project_managers_group.py

+        log.info("Created 'project_managers' group.")
+    else:
+        log.info("'project_managers' group already exists.")
+


If the group already exists, we should quit early (without adding the permission).

Suggested change

if not created:

log.info("'project_managers' group already exists.")

return

log.info("Created 'project_managers' group.")

mathjazz · 2026-02-10T08:26:26Z

pontoon/base/migrations/0106_create_project_managers_group.py

+        ("auth", "0001_initial"),
+        ("contenttypes", "0001_initial"),
+        ("sites", "0001_initial"),


I don't think these are needed?

Suggested change

("auth", "0001_initial"),

("contenttypes", "0001_initial"),

("sites", "0001_initial"),

flodolo · 2026-02-11T15:02:03Z

(removing existing approval for clarity)

Fixes mozilla#3492 HTML atribute values were not being highlighted as placeables in the translation editor, even though the attribute names were highlihted. Added color to match the teal highlighting used in bracket and tags names.

Bumps [django](https://github.com/django/django) from 4.2.27 to 4.2.28. - [Commits](django/django@4.2.27...4.2.28) --- updated-dependencies: - dependency-name: django dependency-version: 4.2.28 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Matjaž Horvat <matjaz.horvat@gmail.com>

Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 5.29.5 to 5.29.6. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Commits](https://github.com/protocolbuffers/protobuf/commits) --- updated-dependencies: - dependency-name: protobuf dependency-version: 5.29.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…mozilla#3950)

Previously, we were indiscriminately reseting failed checks every time the editor result changed, including at the initial load of a translation. This fix checks whether the current editor content differs from the initial loaded content before clearing the warnings.

Bumps [cryptography](https://github.com/pyca/cryptography) from 46.0.3 to 46.0.5. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@46.0.3...46.0.5) --- updated-dependencies: - dependency-name: cryptography dependency-version: 46.0.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Also included: * Unify border radius * Drop obsolete Machinery CSS

…t_managers_group.py

pontoon/base/migrations/0106_create_project_managers_group.py

Fix mozilla#3417: Add data migration to create project_managers group

91b9220

mathjazz approved these changes Feb 6, 2026

View reviewed changes

mathjazz reviewed Feb 6, 2026

View reviewed changes

Update pontoon/base/migrations/0106_create_project_managers_group.py

d4a997a

Co-authored-by: Matjaž Horvat <matjaz.horvat@gmail.com>

flodolo requested a review from mathjazz February 6, 2026 14:08

first-afk added 2 commits February 6, 2026 15:55

Update pontoon/base/migrations/0106_create_project_managers_group.py

357e851

Update pontoon/base/migrations/0106_create_project_managers_group.py

28c8904

mathjazz reviewed Feb 6, 2026

View reviewed changes

first-afk added 3 commits February 7, 2026 00:08

Update pontoon/base/migrations/0106_create_project_managers_group.py

0805068

Update pontoon/base/migrations/0106_create_project_managers_group.py

c2746e7

Update pontoon/base/migrations/0106_create_project_managers_group.py

2ae000e

flodolo reviewed Feb 7, 2026

View reviewed changes

mathjazz reviewed Feb 10, 2026

View reviewed changes

flodolo requested a review from mathjazz February 11, 2026 15:01

MundiaNderi and others added 11 commits February 12, 2026 00:50

Add Search page and Entity translations page (mozilla#3799)

fea9c02

Deprecate standalone Machinery page (mozilla#3926)

32c3b48

Entity view: Sort translations by locale name (mozilla#3945)

2e72ea3

Fix project/locale selector text overflow (mozilla#3932)

2a401bb

Co-authored-by: Matjaž Horvat <matjaz.horvat@gmail.com>

Settings: allow user to remove their own account (mozilla#3927)

6827219

Improve error for missing locale directory during automatic discovery (…

df665a1

…mozilla#3950)

Prevent Search page dropdown text from being cut-off (mozilla#3957)

49022ec

dependabot bot and others added 8 commits February 12, 2026 00:50

Make search icon a button (mozilla#3958)

71bf88c

Also included: * Unify border radius * Drop obsolete Machinery CSS

Fixed mozilla#3417: Update pontoon/base/migrations/0106_create_projec…

21d3f90

…t_managers_group.py

Fixed mozilla#3417: Update pontoon/base/migrations/0106_create_projec…

f8cdcea

…t_managers_group.py

Merge branch 'main' into issue#3417

56b01d7

Fixed mozilla#3417: Update pontoon/base/migrations/0106_create_projec…

ecab991

…t_managers_group.py

Fixed mozilla#3417: Update pontoon/base/migrations/0106_create_projec…

26f0fd1

…t_managers_group.py

Fixed mozilla#3417: Update pontoon/base/migrations/0106_create_projec…

a79ec0b

…t_managers_group.py

mathjazz reviewed Feb 12, 2026

View reviewed changes

pontoon/base/migrations/0106_create_project_managers_group.py Outdated Show resolved Hide resolved

pontoon/base/migrations/0106_create_project_managers_group.py Outdated Show resolved Hide resolved

mathjazz added 2 commits February 12, 2026 09:34

Update pontoon/base/migrations/0106_create_project_managers_group.py

b21ea62

Update pontoon/base/migrations/0106_create_project_managers_group.py

5007b1f

mathjazz reviewed Feb 12, 2026

View reviewed changes

pontoon/base/migrations/0106_create_project_managers_group.py Outdated Show resolved Hide resolved

pontoon/base/migrations/0106_create_project_managers_group.py Outdated Show resolved Hide resolved

mathjazz added 2 commits February 12, 2026 09:55

Update pontoon/base/migrations/0106_create_project_managers_group.py

049d488

Update pontoon/base/migrations/0106_create_project_managers_group.py

4bea3c6

mathjazz reviewed Feb 12, 2026

View reviewed changes

pontoon/base/migrations/0106_create_project_managers_group.py Outdated Show resolved Hide resolved

Update pontoon/base/migrations/0106_create_project_managers_group.py

639c30f

	migrations.RunPython(create_pm_group, remove_pm_group),
	migrations.RunPython(create_pm_group, reverse_code=migrations.RunPython.noop),

	("auth", "0001_initial"),
	("contenttypes", "0001_initial"),
	("sites", "0001_initial"),

Fix #3417: Add data migration to create project_managers group #3948

Are you sure you want to change the base?

Fix #3417: Add data migration to create project_managers group #3948

Conversation

first-afk commented Feb 5, 2026 • edited by mathjazz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Feb 5, 2026

Codecov Report

Uh oh!

mathjazz left a comment

Choose a reason for hiding this comment

Uh oh!

mathjazz commented Feb 6, 2026

Uh oh!

mathjazz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mathjazz Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mathjazz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

first-afk commented Feb 6, 2026

Uh oh!

first-afk commented Feb 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flodolo commented Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

first-afk commented Feb 5, 2026 •

edited by mathjazz

Loading

mathjazz Feb 6, 2026 •

edited

Loading

mathjazz left a comment •

edited

Loading