Translate view: don't try to log UX action for unauthenticated users

[flodolo]

Fixes #3900

Not sure if there's a better way to do it.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.50%. Comparing base (dffde97) to head (9ee9c07).
⚠️ Report is 2 commits behind head on main.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[flodolo]

I tried to use the data already available in the frontend instead of adding info to the Django template.

Just in case, I kept the changes in a separate commit, so it's easy to revert 9f6564b

Worth noting that I'm very much hand waving when writing JavaScript, and even more so when writing tests (asked ChatGPT to write one based on test cases).

P.S. this seems to add an additional call to /user-data, and I couldn't figure out a way to avoid that (e.g. by using getUserData, which got me lost in Redux concepts).

[eemeli]

Re-fetching user data for logging like this is not the right solution; the info is available at least via useAppSelector((state) => state[USER].isAuthenticated). Accesssing that might require renaming some functions to be hooks, or to pass the data along in arguments.

[flodolo]

I think I'm in React/Redux hell. I tried moving the authentication state as a parameter of the existing function, but that required adding it to all props, update calls, tests, etc.

This is how far I manage to go. It works, I'm not sure how correct it is in terms of model (e.g. separation).

[flodolo]

Same here: is this unnecessary?

[flodolo]

Again, trying to wrap my head about React, and failing 😵‍💫

I think this was OK before, because the log was sent once at startup (could we potentially log the wrong number of unread notifications though?). But now it depends on authentication status.

The "multiple notifications" was caused by the log changing each render, so the solution is stabilize that across re-renders?

[flodolo]

I seem to have introduced a bug for "unread notifications", where this action is sent multiple times.