Open
Conversation
We name the client the "dead taker" if it closed connection to Tarantool during xq:take(). Tarantool closes socket and calls callback box.session.on_disconnect and xqueue registers that taker inside this session can't consume tasks anymore. But, if clients sleeps for too long on the xq:take() (ex. 60 seconds) then next taker will receive task only when new task will be produced. It is too long to wait, so this fix implements alarm of the other takers (if there are any) in "dead taker"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dead takers now alarms alive takers to reduce wait time for the next ready task. Read more info in commit message 46744c7
It is possible to replace take-* channels with fiber.cond() but it will lead to enormous fiber wakeups on high load systems