Key generation and installation problems#2
Open
idealisconsultingbe wants to merge 2 commits intomodoolar:10.0from
Open
Key generation and installation problems#2idealisconsultingbe wants to merge 2 commits intomodoolar:10.0from
idealisconsultingbe wants to merge 2 commits intomodoolar:10.0from
Conversation
added 2 commits
August 28, 2018 13:54
Force to set type and priority on task before setting the constrains.
The key generation function is invalid when installing the module with existing project generating the same key. The function has been changed to avoid empty char (caused when double spaced) and to check if the key already exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some correction, to avoid problems when installing on an existing system.
the key generation (existing projects: Project and Project-alpha => same key)
the constraint on type_id (the _set_default_task_type_id seems to let some null in the database) => force to set a type_id with a query
the constraint on priority_id (the _set_default_task_priority_id seems to let some null in the database) => force to set a priority_id with a query