Skip to content

Deprecate repo in favor of modal-labs/modal-client#292

Open
thomasjpfan wants to merge 11 commits intomainfrom
thomasjpfan/deprecated-package
Open

Deprecate repo in favor of modal-labs/modal-client#292
thomasjpfan wants to merge 11 commits intomainfrom
thomasjpfan/deprecated-package

Conversation

@thomasjpfan
Copy link
Contributor

@thomasjpfan thomasjpfan commented Mar 6, 2026

After this we can release a final go tag so users can see all the deprecation warnings.

Linters will catch this warning:

Screenshot 2026-03-09 at 1 27 40 PM

And in my IDE:

Screenshot 2026-03-09 at 1 28 16 PM

For us to migrate:

  1. Do a release of the SDKs for modal-client.
  2. Merge this PR and manually release just the GO SDK.
  3. Archive this repo.

@cursor
Copy link

cursor bot commented Mar 6, 2026

PR Summary

Low Risk
Primarily documentation and compiler/linter deprecation annotations; no functional runtime behavior changes beyond lint configuration.

Overview
Adds prominent migration guidance in README.md and a modal-go/v0.7.3 changelog entry announcing the move to modal-labs/modal-client and providing go get/import replacement instructions.

Marks the entire modal-go module as deprecated by adding // Deprecated: package comments across the Go sources (and go.mod), and updates modal-go/.golangci.toml to suppress specific staticcheck/ST1000 findings related to these deprecations in selected paths.

Written by Cursor Bugbot for commit 5e8f1ba. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

README.md Outdated
- **[Go](./modal-go/README.md)**
Run the following in your project: `go get github.com/modal-labs/modal-client/go@latest`

Replace all imports of `github.com/modal-labs/libmodal/modal-go` with `github.com/modal-labs/modal-client/g`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? Or am I missing something?

Suggested change
Replace all imports of `github.com/modal-labs/libmodal/modal-go` with `github.com/modal-labs/modal-client/g`.
Replace all imports of `github.com/modal-labs/libmodal/modal-go` with `github.com/modal-labs/modal-client/go`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a typo. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants