Improve sandbox error message with JSON.stringify#218
Draft
TakshPSingh wants to merge 1 commit intomodal-labs:mainfrom
Draft
Improve sandbox error message with JSON.stringify#218TakshPSingh wants to merge 1 commit intomodal-labs:mainfrom
TakshPSingh wants to merge 1 commit intomodal-labs:mainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if (resp.taskResult) { | ||
| throw new Error( | ||
| `Sandbox ${this.sandboxId} has already completed with result: ${resp.taskResult}`, | ||
| `Sandbox ${this.sandboxId} has already completed with result: ${JSON.stringify(resp.taskResult)}`, |
There was a problem hiding this comment.
Bug: Serialization Errors Mask Real Problem Messages
JSON.stringify(resp.taskResult) can throw a TypeError if the protobuf object contains circular references, BigInt values, or other non-serializable properties. This would replace the intended error message with a confusing serialization error. The codebase shows awareness of this risk in grpc_mock.ts where JSON.stringify is wrapped in try-catch with a fallback to String().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Improve Sandbox completed error message by JSON-stringifying
taskResultfor clearer output.Written by Cursor Bugbot for commit 60f885e. This will update automatically on new commits. Configure here.