Open
Conversation
Normalize plugin names to facilitate correct reuse of existing plugin instances. Signed-off-by: Paul Pignet <p.pignet@think-modular.com>
ppignet
force-pushed
the
csi/manager_normalize_plugin_name
branch
from
4e54f4f to
4c93e12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3215
Progresses ceph/ceph-csi#3769
- What I did
Modified manager/csi/manager.go:getPlugin so that plugins are uniquely identified by their CSI driver name, not by the Docker plugin image/tag used to install them.
This ensures that all of eg.:
-rbd.csi.ceph.com:latest
-rbd.csi.ceph.com:v3.10.0
-rbd.csi.ceph.com@sha256:...
...refer to the same logical driver instance.
- How I did it
The getPlugin function now normalizes plugin names by stripping any tag suffixes. The normalized name is then used as the key in vm.plugins.
- How to test it
Added Go Test for the addressed failure case.
When run on the unpatched code, it also serves as proof of the issue and fails like expected.
- Description for the changelog
Fix CSI plugin identity handling by normalizing plugin names
to avoid duplicate plugin instances.