Makefile: go-mod-vendor: fix copying of gogo/protobuf#3088
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 19, 2022
Merged
Makefile: go-mod-vendor: fix copying of gogo/protobuf#3088thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Possibly it's using a non-standard location;
cp: cannot stat '/home/circleci/.go_workspace:/usr/local/go_workspace/pkg/mod/github.com/gogo/protobuf@v1.3.2/protobuf': No such file or directory
make: *** [direct.mk:146: go-mod-vendor] Error 1
So, using GOMODCACHE path instead of trying to construct our own.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
d851830 to
02fa156
Compare
Member
Author
|
Hm... flaky test? |
Codecov Report
@@ Coverage Diff @@
## master #3088 +/- ##
=========================================
Coverage ? 62.03%
=========================================
Files ? 156
Lines ? 24618
Branches ? 0
=========================================
Hits ? 15271
Misses ? 7751
Partials ? 1596 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
neersighted
approved these changes
Nov 19, 2022
Member
Author
|
Thx! Let me bring this one in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly it's using a non-standard location;
So, using GOMODCACHE path instead of trying to construct our own.