Libnetwork remove unused args from driver-registry#42572
Libnetwork remove unused args from driver-registry#42572thaJeztah wants to merge 3 commits intomoby:masterfrom
Conversation
There was a problem hiding this comment.
FWIW, the ifn IPAMNotifyFunc is not used anywhere in our code currently either
thaJeztah
added
area/networking
vendor.conf
Outdated
There was a problem hiding this comment.
Temporarily using my fork because of circular dependency
thaJeztah
force-pushed
the
libnetwork_remove_unused_args
branch
2 times, most recently
from
ee639f6 to
5e068d8
Compare
vendor.conf
Outdated
|
|
||
| # cluster | ||
| github.com/docker/swarmkit 3629f50980f6c0dd5ccd7dbfa0956b57ea0cd78d # master | ||
| github.com/docker/swarmkit remove_driverregistry_arg https://github.com/thaJeztah/swarmkit.git # master + https://github.com/docker/swarmkit/pull/3015 |
There was a problem hiding this comment.
oh! yes, this one needs some coordination with @dperny to update moby/swarmkit#3015 once this is merged, and then revendor swarmkit from upstream after that.
Yay for circular dependencies
thaJeztah
force-pushed
the
libnetwork_remove_unused_args
branch
2 times, most recently
from
e077c91 to
ae92825
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
libnetwork_remove_unused_args
branch
from
ae92825 to
b040b08
Compare
corhere
left a comment
corhere
left a comment
There was a problem hiding this comment.
The migration path away from the deprecated drvregistry functions and methods with unused arguments is to migrate to the new drvregistry.Networks and drvregistry.IPAMs types. I was very deliberate in designing the replacements to force consumers to find another way to pass the PluginGetter when initializing the remote driver than by indirecting it through the driver registry. There is no good reason to modify the signatures of deprecated functions which are going away once Swarmkit migrates away from them.
3 participants
related moby/swarmkit#3015