Update pyproject.toml and pdm.lock to lock down the versions of all supporting libraries and tools#257
Open
FileSystemGuy wants to merge 2 commits intomainfrom
Open
Update pyproject.toml and pdm.lock to lock down the versions of all supporting libraries and tools#257FileSystemGuy wants to merge 2 commits intomainfrom
FileSystemGuy wants to merge 2 commits intomainfrom
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
dslik
reviewed
Mar 4, 2026
| "pandas>=1.5.1", | ||
| "psutil>=5.9.8", | ||
| "pydftracer>=2.0.2", | ||
| "tensorflow>=2.13.1", |
There was a problem hiding this comment.
It looks like DLIO is still pulling in TensorFlow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes were originally authored by fortaa in PR#215.
PR#215 was not merged into the repo because fortaa had not signed the CLA and that PR changed another file (READM.md) that we did not want changed, but we did want the other changes in PR#215. As documented in the discussion for PR#215 fortaa gave permission and license to MLCommons under section 5 of the Apache-2.0 license for those changes to be merged in.
In short, I am merging the changes to pyproject.toml and pdm.lock into the repo under a new PR rather than asking fortaa for additional work on their part, with the above notice and credit of original authorship, and our thanks for the contribution.
To the reviewers, since fortaa's original work we may have changed dependent versions, so please check that all versions are correct and there's no extra or missing libraries/tools as part of your review.