fix: use readable file stream instead of reading file into memory#60
Open
fix: use readable file stream instead of reading file into memory#60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the CLI upload path to use streams and
toFile, which affects how file bodies and MIME types are constructed and could surface edge-case regressions in upload behavior (especially for multipart/large files). Scope is limited to the CLI uploader and keeps existing multipart/progress logic largely intact.Overview
Switches CLI store uploads from
readFile+in-memoryFileconstruction to streaming file reads viacreateReadStreamand@mixedbread/sdk/uploadstoFile, avoiding the Node Buffer 2 GiB limit and reducing memory usage for large files.Refactors MIME handling from
fixMimeTypes(File)toresolveMimeType(filePath)and updates both single-file (uploadFile) and batch uploads to compute sizes fromstat().sizebefore creating the stream-backedFileused inclient.stores.files.upload.Written by Cursor Bugbot for commit 2f1b084. This will update automatically on new commits. Configure here.