feat(cli): use multipart uploads for larger files#58
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
For updating file's progress in sync command, should we update one spinner message just like in upload command instead of logging each time? |
… and file size and improve logs
packages/cli/src/utils/sync.ts
Outdated
| `[${completed}/${totalOperations}] Deleted ${path.relative(process.cwd(), file.path)}` | ||
| deleteCompleted++; | ||
| deleteSpinner.message( | ||
| `Deleting ${deleteCompleted}/${deleteTotal} files...` |
Collaborator
There was a problem hiding this comment.
For "files" part, you can use formatCountWithSuffix.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| onProgress(zeroProgress); | ||
| } else { | ||
| log.info( | ||
| `${fileName}: 0/${expectedParts} parts — ${formatBytes(0)}/${formatBytes(totalFileBytes)}` |
Collaborator
There was a problem hiding this comment.
We would also need to use formatCountWithSuffix in this file too, apart from that, lgtm!
nainglinnkhant
approved these changes
Mar 6, 2026
aavshr
force-pushed
the
feat-multipart-uploads
branch
from
c495718 to
f1d76d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Moderate risk because it changes the core file upload path (new multipart config/progress callbacks and updated SDK API) and tweaks the prerelease publishing workflow, which could affect large-file reliability and release automation.
Overview
CLI uploads now support multipart by default for large files. The upload/sync/manifest flows accept new flags (
--multipart-threshold,--multipart-part-size,--multipart-concurrency) and pass these through to the upload layer, which auto-derives sane multipart settings (part size/concurrency) based on file size and system resources.Upload UX and API integration were updated. Upload and sync operations now report progress via spinners (including per-part progress when multipart is used), and the CLI switches to the newer
@mixedbread/sdkupload call shape (includingmultipartUpload+onPartUpload), with tests updated accordingly.Release automation adjustment. The prerelease workflow stops passing
--tagtochangeset publishand includes minor quoting/formatting tweaks.Written by Cursor Bugbot for commit f1d76d0. This will update automatically on new commits. Configure here.