Improve TOML serialization error message for unsupported types#880
Merged
max-sixty merged 1 commit intomitsuhiko:masterfrom Feb 26, 2026
Merged
Improve TOML serialization error message for unsupported types#880max-sixty merged 1 commit intomitsuhiko:masterfrom
max-sixty merged 1 commit intomitsuhiko:masterfrom
Conversation
Replace bare `.unwrap()` with an informative error that shows the original `toml_edit` error and explains TOML's top-level struct/map requirement. Closes mitsuhiko#879 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.unwrap()in TOML serialization with an informative panic that shows the originaltoml_editerror and explains TOML's top-level struct/map requirementCloses #879. Thanks to @ip1981 for reporting.
Before:
After (top-level sequence):
After (unsupported inner type):
Test plan
test_toml_top_level_sequence_unsupportedtest verifies the error messagetest_toml_unit_struct_unsupportedupdated to match improved text