Upgrade ruby version & update SCSS imports#183
Open
smoreface wants to merge 4 commits intominicomp:mainfrom
Open
Upgrade ruby version & update SCSS imports#183smoreface wants to merge 4 commits intominicomp:mainfrom
smoreface wants to merge 4 commits intominicomp:mainfrom
Conversation
update ruby version to 3.4 which is still supported for the next few years and add new dependencies to gemspec to account for gems no longer included by default in 3.4 and 3.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
3.4to avoid deprecations coming with3.2.2: https://www.ruby-lang.org/en/downloads/branches/gemspecfile to account for dependent gems that are no longer included in version 3.4 or 3.5 of Ruby.@usestatements instead of@importas indicated by https://sass-lang.com/documentation/breaking-changes/import/. This also required some reformatting of the files:styles.scsspart of a "with" statement so they would be imported by the_wax.scssfile properly._wax.scssfile that could be overridden by thestyles.scssfile to match the way imports work now.The changes in this PR were tested by:
Some notes:
3.4instead of a more specific version.styles.scssdirectly in_wax.scssgiven the way that imports need to be declared now, but there are still a few things directly stated instyles.scssso I didn't reorganize anything.