Conversation
RedNesto
force-pushed
the
at-overhaul
branch
from
f556e77 to
f53706e
Compare
DenWav
reviewed
Sep 22, 2024
RedNesto
force-pushed
the
at-overhaul
branch
2 times, most recently
from
3e88e0c to
1c7e871
Compare
This should resolved all the highlighting weirdnesses happening while editing ATs, like whole entries being red while correct Also adds a recovery rule for keywords and only use consumeTokenFast for recovery rules, to show users what is wrong with their syntax
AtGotoDeclarationHandler is replaced by proper PsiReferences
They no longer use SRG for member names
Removed redundant code and fixes some false positives
Also fixes AtParserDefinition#spaceExistenceTypeBetweenTokens
Also fixes initial entry indent being 8 spaces instead of none
Pretty much identical to what was done to AT support
RedNesto
force-pushed
the
at-overhaul
branch
from
8d17785 to
a6a4cac
Compare
DenWav
force-pushed
the
dev
branch
4 times, most recently
from
f4dec0b to
5ca2d03
Compare
|
Needs to be merged ngl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2371, fixes #219, fixes #183