Skip to content

Adding SDL3-Mixer port#50358

Open
Honeybunch wants to merge 69 commits intomicrosoft:masterfrom
Honeybunch:sdl3-mixer
Open

Adding SDL3-Mixer port#50358
Honeybunch wants to merge 69 commits intomicrosoft:masterfrom
Honeybunch:sdl3-mixer

Conversation

@Honeybunch
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
    • The project is in Repology: https://repology.org/sdl3-mixer/versions
    • The project is amongst the first web search results for "" or " C++". Include a screenshot of the search engine results in the PR.
    • The port name follows the 'GitHubOrg-GitHubRepo' form or equivalent Owner-Project form.
  • Optional dependencies of the build are all controlled by the port. A dependency is controlled if it is declared an unconditional dependency in vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGE
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is brief and accurate. See adding-usage for context. Don't add a usage file if the automatically generated usage is correct.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

I had published a review for this port before but since upstream wasn't ready for a public release I abandoned that. Now, SDL3-Mixer has a public pre-release and so I'm bringing it back 😄

…mixer

# Conflicts:
#	versions/baseline.json
@Vultraz
Copy link
Contributor

Vultraz commented Mar 9, 2026

The official Mixer 3.2.0 release just dropped: https://github.com/libsdl-org/SDL_mixer/releases/tag/release-3.2.0

@Honeybunch
Copy link
Contributor Author

The official Mixer 3.2.0 release just dropped: https://github.com/libsdl-org/SDL_mixer/releases/tag/release-3.2.0

Ah of course. I will update this when I can

@Honeybunch
Copy link
Contributor Author

Easy enough. No major changes required. If maintainers want I can remove the old prerelease version from the versions list

@BillyONeal
Copy link
Member

The android builds are broken with errors like:

FAILED: [code=1] test/testmixer 
: && /android-ndk-r29/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ --target=x86_64-none-linux-android28 --sysroot=/android-ndk-r29/toolchains/llvm/prebuilt/linux-x86_64/sysroot -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -frtti -fexceptions  -fPIC   -fno-limit-debug-info -Wl,--build-id=sha1 -Wl,--no-rosegment -Wl,--no-undefined-version -Wl,--fatal-warnings -Wl,--no-undefined -Qunused-arguments          -Wl,-u,JNI_OnLoad -Xlinker --dependency-file=test/CMakeFiles/testmixer.dir/link.d test/CMakeFiles/testmixer.dir/testmixer.c.o -o test/testmixer  libSDL3_mixer.a  /mnt/vcpkg-ci/installed/x64-android/debug/lib/libSDL3.a  -lm  -lOpenSLES  -ldl  -llog  -landroid  -lGLESv1_CM  -lGLESv2  -latomic -lm && :
ld.lld: error: undefined symbol: main
>>> referenced by crtbegin.c
>>>               /android-ndk-r29/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/lib/x86_64-linux-android/28/crtbegin_dynamic.o:(_start_main)
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Should building "test" be patched out?

@Honeybunch
Copy link
Contributor Author

Yeah not sure what happened here. I'll have to look into it

@JavierMatosD JavierMatosD marked this pull request as draft March 11, 2026 00:26
@Honeybunch
Copy link
Contributor Author

Yeah upstream turned tests on by default if it's the root project. Reasonable but no good here. Easy to turn off. Compiled locally with my android setup.

@Honeybunch Honeybunch marked this pull request as ready for review March 11, 2026 02:08
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes over the double version in the database. I just pointed out the default features on dependencies to be considered because they're difficult to disable for end users when enabled transitively, but for what is worth none of the features seem to pull extra dependencies.

@vicroms vicroms marked this pull request as draft March 12, 2026 09:24
@Honeybunch Honeybunch marked this pull request as ready for review March 12, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants