[symengine] Fix find TCMALLOC

[FrankXie05]

Fix #33576

All features has been tested successfully locally.

• Changes comply with the maintainer guide
• SHA512s are updated for each updated download
• The "supports" clause reflects platforms that may be fixed by this new version
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[BillyONeal]

Is the tcmalloc port not publishing something it should be publishing? I'm a bit nervous hard coding this path...

[FrankXie05]

@BillyONeal The best way is probably to add port tcmalloc. I will try this。

[BillyONeal]

@BillyONeal The best way is probably to add port tcmalloc. I will try this。

I think there at least needs to be an investigation; this change might still be the correct one but we should ensure tcmalloc can't publish bits that work first.

[FrankXie05]

@BillyONeal The cmake integration for tcmalloc has been in progress, but since bazel and cmake, the syntax and ideas of the two build systems are very different. This progress should not be fast. And it seems they haven't updated or maintained it for a long time.
google/tcmalloc#104

[MonicaLiu0311]

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".

[FrankXie05]

@BillyONeal

[MonicaLiu0311]

Flag info:reviewed for further review.

[data-queue]

I agree, I think the best way is to add the port tcmalloc.

[FrankXie05]

@BillyONeal The best way is probably to add port tcmalloc. I will try this。

Convert to draft.

[BillyONeal]

I agree, I think the best way is to add the port tcmalloc.

The port exists, it just isn't publishing a cmake config this downstream port expects.

[FrankXie05]

Should we export it?

vcpkg/ports/gperftools/CMakeLists.txt

Line 194 in 11cbb6b

install(TARGETS libtcmalloc_minimal

[data-queue]

I think the correct solution is to export libtcmalloc_minimal so find_package will find it.

[FrankXie05]

I think the correct solution is to export libtcmalloc_minimal so find_package will find it.

Ok, I will do it.

[FrankXie05]

I think the correct solution is to export libtcmalloc_minimal so find_package will find it.

Ok, I will do it.

Done.

[FrankXie05]

The usage has been tested successfully.

gperftools provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(unofficial-libtcmalloc_minimal CONFIG REQUIRED)
  target_link_libraries(main PRIVATE unofficial::libtcmalloc_minimal)

[dg0yt]

IIUC the guidelines say that port bar may install unofficial-bar-config.cmake with unofficial::bar::foo,
and so port gperftools may install unofficial-gperftools-config.cmake with unofficial::gperftools::libtcmalloc_minimal.

If gerftools is the right port to install and own this lib.

[vicroms]

Please apply @dg0yt's suggestion

[FrankXie05]

New usage has been verified：

gperftools provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(unofficial-gperftools CONFIG REQUIRED)
  target_link_libraries(main PRIVATE unofficial::gperftools::libtcmalloc_minimal)

[vicroms]

marking requires:vcpkg-team-review to confirm that we're OK with gperftools vendoring tmalloc

[kotori2]

Any update on this PR?

[BillyONeal]

@JavierMatosD
@vicroms
@ras0219-msft
and I discussed today.

The totally unrelated gperftools should not be vendoring TCMALLOC. And we should not be making symengine consume that vendored copy. Sorry for any confusion.

google/tcmalloc#104 <-- Google has had more than enough time given our usual cooldown periods.

I think the path forward is this:

• Add unofficial configs to the port tcmalloc so that CMake customers can use it. This does not necessarily imply building tcmalloc itself with CMake; we can just write configs that do the right thing.
• Fix gperftools to stop vendoring tcmalloc and use the port
• Fix symengine to also use the port tcmalloc

I'm sorry that our 'rotation' process has led to some confusion as we didn't always understand everything when this was handed off between maintainers. I'll look to get this one to some resolution regardless of the 'rotation' mechanism.

[JavierMatosD]

I'm marking this PR draft until review comments have been addressed.

[MonicaLiu0311]

Is there any new progress?

[FrankXie05]

Turn it off temporarily.