Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 24, 2026

The JSDoc for INpmRegistryPackageResponse incorrectly stated it "extends INpmCheckRegistryData" when the interface doesn't use the extends keyword.

Change:

  • Reworded JSDoc to say "structurally compatible with" instead of "extends"

The interface has the same dist-tags and versions fields as INpmCheckRegistryData, making it structurally compatible in TypeScript's type system without formal inheritance.

/**
 * @remarks
 * This interface represents the full response from the npm registry when
 * fetching package metadata. It is structurally compatible with INpmCheckRegistryData
 * to maintain compatibility with existing code like bestGuessHomepage.
 */
export interface INpmRegistryPackageResponse {
  name: string;
  'dist-tags': Record<string, string>;
  versions: Record<string, INpmRegistryVersionMetadata>;
  time?: Record<string, string>;
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix comments on package-json and throat dependency replacements docs(npm-check-fork): fix JSDoc claiming interface extends when it doesn't Jan 24, 2026
Copilot AI requested a review from TheLarkInn January 24, 2026 23:56
@TheLarkInn TheLarkInn marked this pull request as ready for review January 25, 2026 00:18
@TheLarkInn TheLarkInn merged commit 8a4b3a3 into atomic-style-claude Jan 25, 2026
1 check passed
@TheLarkInn TheLarkInn deleted the copilot/sub-pr-5565-again branch January 25, 2026 00:18
@github-project-automation github-project-automation bot moved this from Needs triage to Closed in Bug Triage Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants