Early return for 'some in' statement#427
Merged
anakrish merged 3 commits intomicrosoft:mainfrom Jul 8, 2025
Merged
Conversation
Since 'early return' now works with 'some in' statement, interpreter does not do any evaluation after it found match for rule, therefore we don't have other rule checks after interpeter found match
Contributor
Author
|
@microsoft-github-policy-service agree |
Collaborator
|
@ZabelinK Thanks for the issue and the fix! Can you rebase main? That should take care of the test failure. |
Contributor
Author
|
Sure! Just synced the fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue described here: #426
Introducing early return checks in eval_some_in.
And adjusting kata test output, since there is no more additional checks after rules with 'some in' found a match.
fixes #426