fix: handle null close code and reason in WebSocketRoute #1886
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a WebSocket connection closes due to page navigation, the driver may send close events without code, reason, or wasClean fields. This caused a NullPointerException when accessing these fields directly. Fixes microsoft#1882
nanne-rl
force-pushed
the
fix-websocket-redirect
branch
from
7387843 to
7d1e5d4
Compare
Author
|
I have confirmed the fix works with the test repo nanne-rl/pw-java-websocket-bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a WebSocket connection closes due to page navigation, the driver may send close events without code, reason, or wasClean fields. This caused a NullPointerException when accessing these fields directly.
Fixes #1882