add horizontal scrolling to eventviewer#2361
Open
logangeorge01 wants to merge 2 commits intomicrosoft:mainfrom
Open
add horizontal scrolling to eventviewer#2361logangeorge01 wants to merge 2 commits intomicrosoft:mainfrom
logangeorge01 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
logangeorge01
requested review from
StephenMolloy,
brianrob,
cincuranet,
leculver,
marklio and
mconnew
as code owners
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
brianrob
reviewed
Feb 11, 2026
Member
brianrob
left a comment
brianrob
left a comment
There was a problem hiding this comment.
Looks great! Just one improvement request below.
Member
There was a problem hiding this comment.
I believe this should be cacheable so that you don't have to find it on each event.
Author
There was a problem hiding this comment.
added a commit, let me know if this is what you meant by caching
brianrob
reviewed
Feb 18, 2026
Member
brianrob
left a comment
brianrob
left a comment
There was a problem hiding this comment.
Yes, this is what I'm talking about. Let's see if we can optimize this just a bit more since we're going to go through this path a whole bunch during scrolling. Take a look below - we should be able to eliminate one of the null checks.
| if (m_gridScrollViewer == null) | ||
| { | ||
| m_gridScrollViewer = FindVisualChild<ScrollViewer>((DependencyObject)sender); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| } | |
| if (m_gridScroller == null) | |
| { | |
| return; | |
| } | |
| } |
| m_gridScrollViewer = FindVisualChild<ScrollViewer>((DependencyObject)sender); | ||
| } | ||
|
|
||
| if (m_gridScrollViewer != null) |
Member
There was a problem hiding this comment.
Suggested change
| if (m_gridScrollViewer != null) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for shift+scroll horizontal scrolling in eventviewer