Skip to content

Re-include Linux kmod cert in x64 secure boot template#2896

Merged
mebersol merged 2 commits intomicrosoft:mainfrom
mebersol:user/mebersol/topic_sb_kmod
Mar 9, 2026
Merged

Re-include Linux kmod cert in x64 secure boot template#2896
mebersol merged 2 commits intomicrosoft:mainfrom
mebersol:user/mebersol/topic_sb_kmod

Conversation

@mebersol
Copy link
Collaborator

@mebersol mebersol commented Mar 6, 2026

Trusted Launch VMs should include the Linux kmod certificate for x64

Additionally, add new templates (currently unused) for future confidential scenarios.

@mebersol mebersol requested a review from a team as a code owner March 6, 2026 01:26
Copilot AI review requested due to automatic review settings March 6, 2026 01:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the x64 Hyper-V Secure Boot template set to support Trusted Launch scenarios that require the Linux kmod certificate, and adds placeholder “confidential” x64 template JSON files for future use.

Changes:

  • Re-add the Azure Services Linux Kmod PCA certificate to the x64 MicrosoftUEFICertificateAuthority template’s db.
  • Add new (currently unused) x64 “Confidential” template JSON files for Windows and Microsoft UEFI.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
vm/devices/firmware/hyperv_secure_boot_templates/templates/x64/MicrosoftUEFICertificateAuthority_Template.json Adds the Linux kmod PCA cert to db (aligning x64 with the existing aarch64 template contents).
vm/devices/firmware/hyperv_secure_boot_templates/templates/x64/MicrosoftWindows_Confidential_Template.json New confidential Windows template JSON (not currently referenced by the resource crate API).
vm/devices/firmware/hyperv_secure_boot_templates/templates/x64/MicrosoftUEFI_Confidential_Template.json New confidential UEFI template JSON (not currently referenced by the resource crate API).

Comment on lines +1 to +6
{
"type": "Microsoft.Compute/disks",
"properties": {
"uefiSettings": {
"signatureMode": "Replace",
"signatures": {
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new templates are not referenced by hyperv_secure_boot_templates/src/lib.rs, so they won't be parsed/validated by hyperv_uefi_custom_vars_json::load_template_from_json in unit tests (build.rs only checks JSON syntax via serde_json). Consider adding a lightweight validation test (or wiring them into the template include list) so schema issues are caught now rather than when the templates are first used.

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +6
{
"type": "Microsoft.Compute/disks",
"properties": {
"uefiSettings": {
"signatureMode": "Replace",
"signatures": {
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new templates are not referenced by hyperv_secure_boot_templates/src/lib.rs, so they won't be parsed/validated by hyperv_uefi_custom_vars_json::load_template_from_json in unit tests (build.rs only checks JSON syntax via serde_json). Consider adding a lightweight validation test (or wiring them into the template include list) so schema issues are caught now rather than when the templates are first used.

Copilot uses AI. Check for mistakes.
@mebersol mebersol added backport_2505 Change should be backported to the release/2505 branch backport_1.7.2511 labels Mar 9, 2026
@mebersol mebersol merged commit 794ddea into microsoft:main Mar 9, 2026
92 of 99 checks passed
mebersol added a commit to mebersol/openvmm that referenced this pull request Mar 9, 2026
Trusted Launch VMs should include the Linux kmod certificate for x64

Additionally, add new templates (currently unused) for future
confidential scenarios.
mebersol added a commit to mebersol/openvmm that referenced this pull request Mar 9, 2026
Trusted Launch VMs should include the Linux kmod certificate for x64

Additionally, add new templates (currently unused) for future
confidential scenarios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport_1.7.2511 backport_2505 Change should be backported to the release/2505 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants