repo: Update prost and pbjson crates#2893
Closed
smalis-msft wants to merge 3 commits intomicrosoft:mainfrom
Closed
repo: Update prost and pbjson crates#2893smalis-msft wants to merge 3 commits intomicrosoft:mainfrom
smalis-msft wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the workspace’s protobuf toolchain dependencies (prost + pbjson) and adjusts enum conversion call sites to match newer APIs.
Changes:
- Bump
prost/*from0.11to0.14andpbjson*from0.5to0.9. - Replace
from_i32(...)enum decoding withtry_from(...)and updated error handling. - Remove the temporary
pbjson-buildpatch override.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vm/devices/tdisp_proto/src/lib.rs | Updates enum decoding to try_from(...).ok() for new prost enum API. |
| vm/devices/tdisp/src/serialize_proto.rs | Updates validation macro to use try_from and map conversion failures into anyhow errors. |
| vm/devices/tdisp/src/lib.rs | Updates request handling code paths to match try_from’s Result return type. |
| vm/devices/get/underhill_config/src/schema/v1.rs | Updates version parsing to try_from while preserving “Unknown” fallback behavior. |
| Cargo.toml | Bumps prost/pbjson versions and removes the pbjson-build git patch override. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are quite old, but we've had issues updating them in the past. Let's try again.