Skip to content

repo: Update prost and pbjson crates#2893

Closed
smalis-msft wants to merge 3 commits intomicrosoft:mainfrom
smalis-msft:update-prost
Closed

repo: Update prost and pbjson crates#2893
smalis-msft wants to merge 3 commits intomicrosoft:mainfrom
smalis-msft:update-prost

Conversation

@smalis-msft
Copy link
Contributor

These are quite old, but we've had issues updating them in the past. Let's try again.

@smalis-msft smalis-msft requested a review from a team as a code owner March 5, 2026 20:12
Copilot AI review requested due to automatic review settings March 5, 2026 20:12
@smalis-msft smalis-msft requested a review from a team as a code owner March 5, 2026 20:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the workspace’s protobuf toolchain dependencies (prost + pbjson) and adjusts enum conversion call sites to match newer APIs.

Changes:

  • Bump prost/* from 0.11 to 0.14 and pbjson* from 0.5 to 0.9.
  • Replace from_i32(...) enum decoding with try_from(...) and updated error handling.
  • Remove the temporary pbjson-build patch override.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vm/devices/tdisp_proto/src/lib.rs Updates enum decoding to try_from(...).ok() for new prost enum API.
vm/devices/tdisp/src/serialize_proto.rs Updates validation macro to use try_from and map conversion failures into anyhow errors.
vm/devices/tdisp/src/lib.rs Updates request handling code paths to match try_from’s Result return type.
vm/devices/get/underhill_config/src/schema/v1.rs Updates version parsing to try_from while preserving “Unknown” fallback behavior.
Cargo.toml Bumps prost/pbjson versions and removes the pbjson-build git patch override.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

@smalis-msft smalis-msft closed this Mar 9, 2026
@smalis-msft smalis-msft deleted the update-prost branch March 9, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants