Skip to content

Repo: Fix lints for Rust 1.94#2892

Merged
smalis-msft merged 2 commits intomicrosoft:mainfrom
smalis-msft:rust-194-lints
Mar 9, 2026
Merged

Repo: Fix lints for Rust 1.94#2892
smalis-msft merged 2 commits intomicrosoft:mainfrom
smalis-msft:rust-194-lints

Conversation

@smalis-msft
Copy link
Contributor

Pretty small stuff this time around, but I took the opportunity to clean up PageTableEntry to remove suspicious casting. We should look for more places where we can do the same.

@smalis-msft smalis-msft requested a review from a team as a code owner March 5, 2026 19:23
Copilot AI review requested due to automatic review settings March 5, 2026 19:23
@smalis-msft smalis-msft enabled auto-merge (squash) March 5, 2026 19:23
@github-actions github-actions bot added the unsafe Related to unsafe code label Mar 5, 2026
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

⚠️ Unsafe Code Detected

This PR modifies files containing unsafe Rust code. Extra scrutiny is required during review.

For more on why we check whole files, instead of just diffs, check out the Rustonomicon

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@smalis-msft smalis-msft merged commit 3e10ca0 into microsoft:main Mar 9, 2026
60 checks passed
@smalis-msft smalis-msft deleted the rust-194-lints branch March 9, 2026 19:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@@ -2224,8 +2224,8 @@ impl NvspMessage {
// Note that vmbus packets are always 8-byte multiples, so round the
// protocol package size up.
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the comment: “protocol package size” reads like it refers to a software package; it seems this should be “protocol packet size”.

Suggested change
// protocol package size up.
// protocol packet size up.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

unsafe Related to unsafe code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants