address_filter: Fix parsing of 'all'#2889
Merged
smalis-msft merged 3 commits intomicrosoft:mainfrom Mar 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in AddressFilter::from_str where the "all" keyword was incorrectly compared against the full input string s instead of the current range token inside the comma-splitting loop. This caused "all" to be treated as a range within the loop, where it would conflict with the overlap checking logic when combined with other ranges. The fix moves the "all" check outside the loop as a top-level special case.
Changes:
- Restructured
from_strto handle"all"as a top-level special case before the comma-splitting loop, fixing thes == "all"vsrange == "all"bug. - Added comprehensive unit tests covering all parsing paths:
"all","?", single address, range, compound filter, error cases (end-before-start, overlapping, missing prefix, nested all), and empty filter.
You can also share your feedback on Copilot code review. Take the survey.
smalis-msft
commented
Mar 5, 2026
mattkur
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"all" should be treated as a special case here, not just a subrange. Otherwise it'll conflict with any other ranges. Fix parsing to handle this properly. Vibe coded with Claude