Skip to content

underhill_core: print branch in addition to crate #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattkur wants to merge 1 commit into
base: main
Choose a base branch
from
Open

underhill_core: print branch in addition to crate #2880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions openhcl/build_info/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ impl BuildInfo {
pub fn scm_branch(&self) -> &'static str {
self.branch
}

pub fn openhcl_version(&self) -> &'static str {
self.openhcl_version
}
}

// Placing into a separate section to make easier to discover
Expand Down
9 changes: 8 additions & 1 deletion openhcl/underhill_core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,14 @@ async fn do_main(driver: DefaultDriver, mut tracing: TracingBackend) -> anyhow::

let crate_name = build_info::get().crate_name();
let crate_revision = build_info::get().scm_revision();
tracing::info!(CVM_ALLOWED, ?crate_name, ?crate_revision, "VMM process");
let openhcl_version = build_info::get().openhcl_version();
tracing::info!(
CVM_ALLOWED,
?crate_name,
?crate_revision,
?openhcl_version,
"VMM process"
Comment on lines 194 to +202
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description/title mention printing the SCM branch, but this log adds openhcl_version and still does not emit scm_branch (available as build_info::get().scm_branch()). If the goal is to identify which git branch produced the build, log scm_branch here (optionally alongside openhcl_version if that’s also useful).

Copilot uses AI. Check for mistakes.
);
log_boot_times().context("failure logging boot times")?;

// Write the current pid to a file.
Expand Down
Loading