Skip to content

ci: no unstable test helpers in vmgstool releases#2848

Open
tjones60 wants to merge 3 commits intomicrosoft:mainfrom
tjones60:vmgstool_release_notesthelpers
Open

ci: no unstable test helpers in vmgstool releases#2848
tjones60 wants to merge 3 commits intomicrosoft:mainfrom
tjones60:vmgstool_release_notesthelpers

Conversation

@tjones60
Copy link
Collaborator

@tjones60 tjones60 commented Feb 27, 2026 •
edited
Loading

Release versions of vmgstool shouldn't include the unstable test helpers. Build a version without the feature to publish, while still building with the feature for VMM tests.

Copilot AI review requested due to automatic review settings February 27, 2026 01:37
@tjones60 tjones60 requested a review from a team as a code owner February 27, 2026 01:37
Copilot AI reviewed Feb 27, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

At least one Petri test failed.

@mattkur
Copy link
Contributor

mattkur commented Feb 27, 2026

What tests depend on these test helpers? Are we not running those tests in the release CI?

@mattkur mattkur requested a review from Copilot February 27, 2026 17:56
Copilot AI reviewed Feb 27, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

chris-oo
chris-oo previously approved these changes Feb 27, 2026
View reviewed changes
@smalis-msft smalis-msft added the release-ci-required Add to a PR to trigger PR gates in release mode label Feb 27, 2026
@tjones60
Copy link
Collaborator Author

tjones60 commented Feb 27, 2026 •
edited
Loading

What tests depend on these test helpers? Are we not running those tests in the release CI?

There aren't any integration tests for these test helpers, only unit tests which are unaffected by this change.

Nevermind, I do use the test helpers in vmm tests. Maybe I should just build both, won't take long.

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

At least one Petri test failed.

@tjones60 tjones60 changed the title ci: dont build test helpers in release versions of vmgstool ci: dont include unstable test helpers in release versions of vmgstool Feb 27, 2026
@tjones60 tjones60 changed the title ci: dont include unstable test helpers in release versions of vmgstool ci: no unstable test helpers in vmgstool releases Feb 27, 2026
@tjones60 tjones60 requested a review from a team as a code owner February 27, 2026 22:42
@mattkur mattkur requested a review from Copilot March 2, 2026 21:48
Copilot AI reviewed Mar 2, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chris-oo chris-oo chris-oo left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

release-ci-required Add to a PR to trigger PR gates in release mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tjones60 @mattkur @chris-oo @smalis-msft