chore: switch to @tony.ganchev/eslint-plugin-header#27663
Open
tonyganchev wants to merge 1 commit intomicrosoft:mainfrom
Open
chore: switch to @tony.ganchev/eslint-plugin-header#27663tonyganchev wants to merge 1 commit intomicrosoft:mainfrom
tonyganchev wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Hi, team, I noticed you are using _eslint-plugin-header_ with the schema-turn-off workaround to support ESLint 9. I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to address this issue hoped it would be a temporary measure but since the original has not been updated for five years I decided to continue improving the new plugin. Specific improvements include: - full JSON schema for validating the configuration. - fixed multiple bugs with the behavior of the plugin on Windows. - improved autofixing and error-reporting behavior. - added support for leading pragma comments before the header such as `@jest-environment`. This fork is already widely used by other Microsoft projects especially in the VSCode plugin ecosystem (and I have sent a similat PR proposal to the core VSCode maintainers). Looking forward for your feedback. Signed-off-by: Tony Ganchev <tony.ganchev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, team,
I noticed you are using eslint-plugin-header with the schema-turn-off
workaround to support ESLint 9.
I forked @tony.ganchev/eslint-plugin-header mid-2024 to address this
issue and hoped it would be a temporary measure but since the original has
not been updated for five years I decided to continue improving the new
plugin. Specific improvements include:
@jest-environment.This fork is already widely used by other Microsoft projects especially
in the VSCode plugin ecosystem (and I have sent a similar PR proposal
to the core VSCode maintainers).
Looking forward to your feedback.
Signed-off-by: Tony Ganchev tony.ganchev@gmail.com