Skip to content

DRAFT: Plugin EP profiling APIs#27649

Draft
adrianlizarraga wants to merge 4 commits intomainfrom
adrianl/PluginEp_ProfilingApis
Draft

DRAFT: Plugin EP profiling APIs#27649
adrianlizarraga wants to merge 4 commits intomainfrom
adrianl/PluginEp_ProfilingApis

Conversation

@adrianlizarraga
Copy link
Contributor

Description

Draft of profiling APIs for plugin EPs. Ported from existing internal APIs:

virtual std::unique_ptr<profiling::EpProfiler> GetProfiler() {

Motivation and Context

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

OrtEpProfilingEventCategory category; ///< Event category.
int32_t process_id; ///< Process ID.
int32_t thread_id; ///< Thread ID.
const char* event_name; ///< Null-terminated event name. EP-owned.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const char* event_name; ///< Null-terminated event name. EP-owned.
const char* event_name; ///< Null-terminated event name. EP-owned.

const char* event_name; ///< Null-terminated event name. EP-owned.
int64_t timestamp_us; ///< Timestamp in microseconds.
int64_t duration_us; ///< Duration in microseconds.
const char* const* arg_keys; ///< Array of null-terminated argument key strings. EP-owned.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const char* const* arg_keys; ///< Array of null-terminated argument key strings. EP-owned.
const char* const* arg_keys; ///< Array of null-terminated argument key strings. EP-owned.

int64_t duration_us; ///< Duration in microseconds.
const char* const* arg_keys; ///< Array of null-terminated argument key strings. EP-owned.
///< Can be NULL if num_args is 0.
const char* const* arg_values; ///< Array of null-terminated argument value strings. EP-owned.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const char* const* arg_values; ///< Array of null-terminated argument value strings. EP-owned.
const char* const* arg_values; ///< Array of null-terminated argument value strings. EP-owned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant