Fix WebGPU device destroyed on session release, breaking session recreation#27634
Open
nico-martin wants to merge 4 commits intomicrosoft:mainfrom
Open
Fix WebGPU device destroyed on session release, breaking session recreation#27634nico-martin wants to merge 4 commits intomicrosoft:mainfrom
nico-martin wants to merge 4 commits intomicrosoft:mainfrom
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We had a weird behavior in Transformers.js V4. After calling
InferenceSession.release()on a WebGPU session, attempting to create a new WebGPU session fails with:In Transformers.js we encourage the use of the
create -> release -> createpattern, because we expect the application to run for some time and might use multiple models. So it makes sense to unload models after the job is done.It seems like this was introduced in e03631ee528, which added the
preserveDeviceoption with a default value offalse. When the last session is released andpreserveDevice=false, the C++ side destroys the WebGPU device, but the JavaScript reference inenv.webgpu.deviceis never cleared, leaving a stale reference to a destroyed device.Changes
Clear stale device reference when lost (
backend-webgpu.ts)configurable: trueto allow deletiondispose()to detect device loss viadevice.lostpromiseenv.webgpu.devicereferenceThis allows subsequent session creation to acquire a fresh device instead of attempting to reuse a lost one.