Merged PR 14700321: Protect AziHsm from loading unless manticore is present#46
Merged
maheeraeron merged 1 commit intomicrosoft:mainfrom Feb 6, 2026
Merged
Conversation
…resent This PR aims to do a couple things: 1. Adds a new bit to the UefiConfigBlob for enablement of the AziHsm device -> Configures `PcdAziHsmEnabled` 2. Prevents the AziHsmDxe driver from loading unless a TPM is present, via [Depex] on a TPM protocol guid existing 3. DriverEntry in AziHsmDxe will do _nothing_ unless the `PcdAziHsmEnabled` is true ---- #### AI description (iteration 3) #### PR Classification This pull request implements a feature gating mechanism to prevent the AziHsm driver from loading when not explicitly enabled, addressing a release-blocking TPM interaction issue. #### PR Summary The changes add a new configuration flag (PcdAziHsmEnabled) that controls whether the AziHsm driver is loaded, along with corresponding debugging and configuration updates across multiple package files. This ensures the driver only interacts with TPM when intended. - `AziHsmDxe.c`: Introduced a check on PcdAziHsmEnabled to bypass driver loading and log a debug message. - `AziHsmDxe.inf`, `MsvmPkgX64.dsc`, `MsvmPkg.dec`, and `MsvmPkgAARCH64.dsc`: Added and configured the new PcdAziHsmEnabled token with a default value of FALSE. - `BiosInterface.h` and `PlatformPei/Config.c`: Extended UEFI configuration flags and debug output to include the AziHsmEnabled flag. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #60970838
mebersol
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to do a couple things:
PcdAziHsmEnabledPcdAziHsmEnabledis true