Skip to content

[REBASE & FF]Pulling in CHERRY-PICKS from release/202502#1691

Merged
Raymond-MS merged 6 commits intomicrosoft:release/202511from
Raymond-MS:personal/rdiaz/Edk2CherryPicks
Mar 12, 2026
Merged

[REBASE & FF]Pulling in CHERRY-PICKS from release/202502#1691
Raymond-MS merged 6 commits intomicrosoft:release/202511from
Raymond-MS:personal/rdiaz/Edk2CherryPicks

Conversation

@Raymond-MS
Copy link
Contributor

@Raymond-MS Raymond-MS commented Mar 11, 2026

Description

Pulling in the CHERRY-PICKS from release/202502 related to removing globals from ArmFfaCommon which came from EDK2.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

N/A

Integration Instructions

N/A

@Raymond-MS Raymond-MS requested review from apop5 and kuqin12 March 11, 2026 23:19
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/202511@4de8ea1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
MdeModulePkg/Library/ArmFfaLib/ArmFfaSecRxTxMap.c 0.00% 35 Missing ⚠️
MdeModulePkg/Library/ArmFfaLib/ArmFfaPeiLib.c 0.00% 31 Missing ⚠️
MdeModulePkg/Library/ArmFfaLib/ArmFfaSecLib.c 0.00% 9 Missing ⚠️
MdeModulePkg/Library/ArmFfaLib/ArmFfaDxeLib.c 0.00% 7 Missing ⚠️
...odulePkg/Library/ArmFfaLib/ArmFfaStandaloneMmLib.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202511    #1691   +/-   ##
=================================================
  Coverage                  ?    1.58%           
=================================================
  Files                     ?      634           
  Lines                     ?   232380           
  Branches                  ?      420           
=================================================
  Hits                      ?     3672           
  Misses                    ?   228693           
  Partials                  ?       15           
Flag Coverage Δ
MdeModulePkg 1.58% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Added ArmFfaLibIsFfaSupported to ArmFfaCommon to allow for
queries of FF-A support outside of ArmFfaCommonInit.

Signed-off-by: Raymond Diaz <raymonddiaz@microsoft.com>
Removed global variables in ArmFfaCommon. Moved the globals to
locals in each phase's ArmFfaLib implementation. SEC and PEI
will query when necessary to avoid setting globals when memory
is unavailable.

Signed-off-by: Raymond Diaz <raymonddiaz@microsoft.com>
Removed the global variables in ArmFfaSecRxTxMap. Rx/Tx
buffer HOB is now created within the Map function rather
than in the constructor of ArmFfaSecLib. This allows for
the use of the HOB to find the Rx/Tx buffer information.

Signed-off-by: Raymond Diaz <raymonddiaz@microsoft.com>
…TxMap

Replaced all instances of PcdGet64 (PcdFfaTxRxPageCount) *
EFI_PAGE_SIZE, with EFI_PAGES_TO_SIZE macro.

Signed-off-by: Raymond Diaz <raymonddiaz@microsoft.com>
Cleaned various comments and debug messages as well as
headers to either fix typos or for readability.

Signed-off-by: Raymond Diaz <raymonddiaz@microsoft.com>
Add Unmap callback for when PEI and SEC need to invalidate the
Rx/Tx buffer HOB on a call to Unmap.

Signed-off-by: Raymond Diaz <raymonddiaz@microsoft.com>
@Raymond-MS Raymond-MS force-pushed the personal/rdiaz/Edk2CherryPicks branch from 46c5cad to 8363f22 Compare March 12, 2026 00:25
@makubacki
Copy link
Member

@Raymond-MS, fyi, I updated the PR description to have "impacts functionality" checked.

@Raymond-MS
Copy link
Contributor Author

@Raymond-MS, fyi, I updated the PR description to have "impacts functionality" checked.

Apologies for forgetting again! Thank you!

@Raymond-MS Raymond-MS merged commit 6f2cd45 into microsoft:release/202511 Mar 12, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants