[Rebase&FF] Apply memory protections#1660
Merged
apop5 merged 3 commits intomicrosoft:release/202511from Mar 6, 2026
Merged
Conversation
os-d
reviewed
Feb 26, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1660 +/- ##
=================================================
Coverage ? 1.84%
=================================================
Files ? 1150
Lines ? 375774
Branches ? 3196
=================================================
Hits ? 6936
Misses ? 368782
Partials ? 56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apop5
force-pushed
the
personal/apop5/missedmemoryprotections
branch
2 times, most recently
from
6aaa066 to
cdd4b3c
Compare
os-d
reviewed
Mar 2, 2026
apop5
force-pushed
the
personal/apop5/missedmemoryprotections
branch
from
cdd4b3c to
47050b7
Compare
os-d
reviewed
Mar 3, 2026
apop5
force-pushed
the
personal/apop5/missedmemoryprotections
branch
2 times, most recently
from
2c97b9a to
97df7ab
Compare
Member
|
@apop5, can you please notify me when you have pushed the final set of expected changes to the PR? |
Collaborator
Author
|
this PR is ready, and there is another one in mu_plus to get paging audit working on arm 5 level page tables. |
os-d
approved these changes
Mar 4, 2026
apop5
force-pushed
the
personal/apop5/missedmemoryprotections
branch
from
97df7ab to
5d3c7bf
Compare
makubacki
approved these changes
Mar 5, 2026
apop5
force-pushed
the
personal/apop5/missedmemoryprotections
branch
2 times, most recently
from
086f854 to
7d16163
Compare
os-d
approved these changes
Mar 5, 2026
apop5
force-pushed
the
personal/apop5/missedmemoryprotections
branch
from
7d16163 to
196843a
Compare
apop5
force-pushed
the
personal/apop5/missedmemoryprotections
branch
from
196843a to
9c36998
Compare
…lGuid is installed." This reverts commit 815bce9. gEdkiiGcdSyncCompleteProtocolGuid, in 202502, was installed by CpuDxe after CpuArchProtocol was installed and the Page Tables and Gcd has been sycned. This was done to delay memory protections from being fully enabled until CpuArchProtocol was available, which was required for enabling RP on free memory. With the removal of RP on free, gEdkiiGcdSyncCompleteProtocolGuid is no longer notified, and it not necessary. Reducing an override by removing this.
…() (microsoft#228)" This reverts commit 9d19f88. gEdkiiGcdSyncCompleteProtocolGuid, in 202502, was installed by CpuDxe after CpuArchProtocol was installed and the Page Tables and Gcd has been sycned. This was done to delay memory protections from being fully enabled until CpuArchProtocol was available, which was required for enabling RP on free memory. With the removal of RP on free, gEdkiiGcdSyncCompleteProtocolGuid is no longer notified, and it not necessary. Reducing an override by removing this.
Apply memory protections to newly allocated memory in guard pages. Missed during integration removal of RP on free. When calling UnProtectUefiImage, instead of setting back to RWX, ensure XP is applied to freed memory region. When calling GetPermissionAttributeForMemoryType, add back the region's Nx bit setting by default. Missed during integration removal of RP on free.
apop5
force-pushed
the
personal/apop5/missedmemoryprotections
branch
from
9c36998 to
9c9e6ac
Compare
os-d
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During removal of Rp on Freed memory, some corner cases were also removed.
Apply the corner cases to allow for clean dxe paging audit.
How This Was Tested
Q35 DxePagingAuditTestApp was reporting missing memory protection regions.
After fixes, DxePagingAuditTestApp reports passing.
Integration Instructions
No integration necessary.