Skip to content

[cherry-pick] chore: update Go to 1.26.0 #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mancbg merged 1 commit into from
Feb 25, 2026
Merged

[cherry-pick] chore: update Go to 1.26.0 #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pipelines/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- task: GoTool@0
inputs:
version: '1.25.3'
version: '1.26'
Comment on lines 19 to +21
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GoTool@0 was previously pinned to a patch version (e.g., 1.25.3), but is now set to 1.26. If the task resolves this to “latest 1.26.x”, builds become less reproducible; if it requires a patch version, the pipeline may fail. Consider pinning to the intended patch release (e.g., 1.26.0) to match the PR description and keep CI deterministic.

Copilot uses AI. Check for mistakes.
- task: InstallSSHKey@0
inputs:
knownHostsEntry: '$(KNOWN_HOST)'
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
steps:
- task: GoTool@0
inputs:
version: '1.25.3'
version: '1.26'
Comment on lines 79 to +81
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the Build job: the Lint job sets GoTool@0 to 1.26 instead of a pinned patch version. Consider using the exact patch (e.g., 1.26.0) for determinism and to avoid potential task/version parsing issues.

Copilot uses AI. Check for mistakes.

- script: |
make golangci-lint
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ all: format test

.PHONY: tidy
tidy:
go mod tidy
-go mod tidy -e
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tidy target now ignores go mod tidy failures (leading -) and also runs with -e (proceed despite errors). This can mask real module/dependency problems and let CI/lint pass with an invalid or out-of-date go.mod/go.sum. Prefer failing the build on tidy errors (remove the leading -, and only keep -e if there is a well-justified, documented reason).

Suggested change
-go mod tidy -e
go mod tidy

Copilot uses AI. Check for mistakes.

format:
gofmt -s -w rpc/ pkg/
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/microsoft/moc

go 1.25.0
go 1.26

require (
github.com/go-logr/logr v1.4.3
Expand Down