Padding fix for Action text when trailing icon is absent#821
Draft
pranjal-glowingstar wants to merge 1 commit intomicrosoft:masterfrom
Draft
Padding fix for Action text when trailing icon is absent#821pranjal-glowingstar wants to merge 1 commit intomicrosoft:masterfrom
pranjal-glowingstar wants to merge 1 commit intomicrosoft:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem :-
The action text present within the snackbar appears close to the right edge of the snackbar. However, with an icon present, there is more gap from the right edge. The same (or whatever seems appropriate) should also be followed with the action text.
Root cause :-
The modifier for trailing icon absent had only start padding but not the end padding.
Fix :-
Added the padding for the case of trailing icon absent as well.
Validations :-
Build successful and behaviour is working as expected.
(how the change was tested, including both manual and automated tests)
Screenshots
Pull request checklist
This PR has considered: