Skip to content

Padding fix for Action text when trailing icon is absent#821

Draft
pranjal-glowingstar wants to merge 1 commit intomicrosoft:masterfrom
pranjal-glowingstar:pranjal/iconPaddingFix
Draft

Padding fix for Action text when trailing icon is absent#821
pranjal-glowingstar wants to merge 1 commit intomicrosoft:masterfrom
pranjal-glowingstar:pranjal/iconPaddingFix

Conversation

@pranjal-glowingstar
Copy link

Problem :-

The action text present within the snackbar appears close to the right edge of the snackbar. However, with an icon present, there is more gap from the right edge. The same (or whatever seems appropriate) should also be followed with the action text.

Root cause :-

The modifier for trailing icon absent had only start padding but not the end padding.

Fix :-

Added the padding for the case of trailing icon absent as well.

Validations :-

Build successful and behaviour is working as expected.

(how the change was tested, including both manual and automated tests)

Screenshots

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • Automated Tests
  • Documentation and demo app examples
  • VoiceOver and Keyboard Accessibility
  • Internationalization and RTL layouts
  • Size classes and window sizes (notched devices, multitasking, different window sizes, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant