[StackableSnackbar]Adding dismissable property to individual snackbars#818
Open
pranjal-glowingstar wants to merge 2 commits intomicrosoft:masterfrom
Open
[StackableSnackbar]Adding dismissable property to individual snackbars#818pranjal-glowingstar wants to merge 2 commits intomicrosoft:masterfrom
pranjal-glowingstar wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Contributor
|
@pranjal-glowingstar please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem :-
Currently the ui component supports swipe to dismiss behavior and that can be configured at the stack level and not at the individual message level.
As of the design we require individual message to have different behavior for swipe to dismiss. Ask over here is to move this behavior to individual message level rather than having at the container level.
Root cause :-
The flag for enableSwipeToDismiss is at snackbar level and not at message level.
Fix :-
The functionality is now added per individual message level now. Flag is shifted from stack to SnackBarItemModel. Usecase will now have power to define which message to be dismissible and which one not.
Validations :-
Build successful and behaviour is working as expected.
(how the change was tested, including both manual and automated tests)
Screenshots
Pull request checklist
This PR has considered: