Draft
Conversation
Member
|
It's not really possible to delete PRs, but it's fine. If you have any specific questions regarding git, please let me know (e.g. how to forcefully update a branch with your local changes, etc.). Please feel free to just keep pushing into your branch though. When we merge this, we'll "squash" (flatten) its entire history into a single commit anyway. 🙂 |
Contributor
Author
Yeah,I tried to filter-branch replace my email, which resulted in my pr having whole commit history... Right now I want to get some feedback on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for #332
Ignore the keyge variable name, I don't know how to name it yet.
For now, I made draw_editor.rs:draw_goto_menu work, so I can play with implementation.
Migrationot this system does not require us ot migrate the whole editor at once.
All feedback is highly appreciated!
Btw @lhecker, can you clean up my previous attempts on creating a proper PR? I suck at git so hard...