update readme adding instructions for local setup#191
Open
Conversation
kaibocai
requested review from
cgillum and
shreyas-gopalakrishna
as code owners
Member
Author
|
cc @skyao |
cgillum
reviewed
Jan 30, 2024
| One thing to note in the local setup: | ||
|
|
||
| Replace the variable at https://github.com/microsoft/durabletask-java/blob/b3e2d3ab9dfc07495f830d90b00d7fac35009ea0/client/build.gradle#L20 | ||
| with your local `$JAVA_HOME`, the version needs to be equal or higher than Java11 for example: |
Member
There was a problem hiding this comment.
Can't the build.gradle script just do this automatically? Why doesn't it use $JAVA_HOME today?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
This PR updates readme adding instructions for local setup
Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information