Conversation
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java
Outdated
Show resolved
Hide resolved
| <DefaultItemExcludes>**</DefaultItemExcludes> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.DurableTask" Version="2.9.2" /> |
There was a problem hiding this comment.
Using this config is currently resulting in the below exception. Should we wait for next bundle release?
There was a problem hiding this comment.
@davidmrdavid how close are we to completing the v2.9.3 extension release?
There was a problem hiding this comment.
Looks like the v2.9.3 extension release is in the validation stage right now.
There was a problem hiding this comment.
@shreyas-gopalakrishna , Can we try again without this .csproj file, the v2.9.3 should be included in the extension bundle by now. Thanks.
shreyas-gopalakrishna
requested review from
cgillum and
kaibocai
as code owners
| <DefaultItemExcludes>**</DefaultItemExcludes> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.DurableTask" Version="2.9.2" /> |
There was a problem hiding this comment.
@davidmrdavid how close are we to completing the v2.9.3 extension release?
samples-azure-functions/src/main/java/com/functions/RewindInstance.java
Outdated
Show resolved
Hide resolved
samples-azure-functions/src/main/java/com/functions/RewindInstance.java
Outdated
Show resolved
Hide resolved
samples-azure-functions/src/main/java/com/functions/RewindInstance.java
Outdated
Show resolved
Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java
Outdated
Show resolved
Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java
Outdated
Show resolved
Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java
Outdated
Show resolved
Hide resolved
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
Added more comments.
Moving forward, please be especially mindful about variable naming. Poor variable names can make it a lot harder to correctly understand and review code. It can also be a distraction. Good variable naming, on the other hand, can make everything much easier to understand quickly and makes the overall code feel more professional and polished.
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java
Outdated
Show resolved
Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java
Outdated
Show resolved
Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java
Outdated
Show resolved
Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java
Outdated
Show resolved
Hide resolved
samples-azure-functions/src/test/java/com/functions/EndToEndTests.java
Outdated
Show resolved
Hide resolved
shreyas-gopalakrishna
force-pushed
the
shreyasg/rewind
branch
from
bc1954b to
55502ab
Compare
3 participants
Issue describing the changes in this PR
resolves #65
Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information