Python: MCP sample bugbash fixes#4001
Merged
giles17 merged 2 commits intomicrosoft:mainfrom Feb 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes API usage errors in two MCP sample files discovered during a bugbash. The changes correct parameter names and values in the get_mcp_tool() method call to match the actual API signature, and add the standard if __name__ == "__main__" pattern to make one sample executable.
Changes:
- Fixed
get_mcp_tool()parameter names from internal dict keys (server_label, server_url, require_approval) to correct API parameters (name, url, approval_mode) - Fixed approval_mode value from "never" to "never_require"
- Added
if __name__ == "__main__"block to mcp_api_key_auth.py for direct execution
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/samples/02-agents/mcp/mcp_github_pat.py | Corrects get_mcp_tool() parameters from internal dict keys to proper API parameters (server_label→name, server_url→url, require_approval→approval_mode) and fixes approval value ("never"→"never_require") |
| python/samples/02-agents/mcp/mcp_api_key_auth.py | Adds standard if __name__ == "__main__" block with asyncio import to enable direct script execution |
eavanvalkenburg
approved these changes
Feb 17, 2026
TaoChenOSU
approved these changes
Feb 17, 2026
TaoChenOSU
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes errors from two MCP samples found during bugbash
Description
Contribution Checklist