.NET: Preserve and propagate CreatedAt through workflows#3930
Open
nicoleserafino wants to merge 4 commits intomicrosoft:mainfrom
Open
.NET: Preserve and propagate CreatedAt through workflows#3930nicoleserafino wants to merge 4 commits intomicrosoft:mainfrom
nicoleserafino wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where CreatedAt timestamps from individual messages were not being properly propagated when converting AgentResponse to AgentResponseUpdate objects. The issue was caused by a no-op self-assignment that always used the response's timestamp instead of preferring the message's timestamp when available.
Changes:
- Fixed timestamp propagation in
ToAgentResponseUpdates()to use null-coalescing assignment (message.CreatedAt ?? this.CreatedAt)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
CreatedAt wasn’t being propagated from incoming messages into the workflow state because the code was assigning the property to itself. This fixes the loss of the CreatedAt value during workflow transitions. Previously, even when the upstream step populated message.CreatedAt, the value never made it into the workflow entity.
Description
Replace no-op self-assignment with null-coalescing assignment:
CreatedAt = message.CreatedAt ?? this.CreatedAt;This ensures incoming timestamps are applied when provided and prevents overwriting with null.
Contribution Checklist