Open
Conversation
This PR implements suggestions raised in the official API review of `Microsoft.Windows.Storage.Pickers` APIs (#5634 ). 1. Removal of `SettingsIdentifier` Property. 2. Replace method `TrySetSuggestedSaveFilePath` with the property's own setter. 3. For FileSavePicker, updated underlying logic to ensure that the file name in `SuggestedSaveFilePath` takes precedence over the `SuggestedFileName`, even if the folder of `SuggestedSaveFilePath` does not exists. This is also the existing behavior of UWP pickers ( the `Windows.Storage.Pickers`) 4. Test Additions and Updates. 5. XML and Feature Flag Cleanup.
* Add WinUISDKReferences = false to the packaged, single packaged, and unit test projects for the C# and cpp templates * Add WinUISDKReferences is false to ClassLibrary template * Update WapProjTemplate to include 'WinUISDKReferences=false' * Add WinUISDKReferences=false to cppwinrt wapproj template and cpp rt component project template
* Fix CS0649 warnings by converting CertValidation fields to properties * clear warnings in foundation * remove vsbuild createLogFile --------- Co-authored-by: Qiutong Shen <qiutongshen@microsoft.com>
…on/_git/WindowsAppSDKAggregator build 1.8.250728001-experimental (#5659) Microsoft.WindowsAppSDK.Base From Version 1.8.250721001-experimental -> To Version 1.8.250728001-experimental Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
changes to GitHub resource management policies
* SuggestedFolder * update tests
* create the files for official API review * add spec notes for official review * update doc * add details; graceful * update the specs * Resolve comments; Fix typos and grammer errors in doc. * FileSavePicker.SuggestedFolder
The official spec has been merged via * #5634 This PR removes the unofficial spec.
…5668) * Small tweaks I needed to do to build locally * Adding comment * Changing another instance of the get service method
Co-authored-by: Haonan Tang (from Dev Box) <haonantang@microsoft.com>
…taticValidationTests stage (#5698) * Update windows-sdk.ps1 * Update WindowsAppSDK-StaticValidationTest-Stage.yml * Update windows-sdk.ps1 * Update windows-sdk.ps1 * Update windows-sdk.ps1 * Update WindowsAppSDK-BuildInstaller-Stage.yml
* Fixing configuration for MRT * Removing the foreach loop * Fixing binlog location
…sociation class (#5696) * Using lowercase seed so hash gets case insentitive * Simplifying transform call
#5707) * Fixing the testdef name file to the correct one for AppLifecycle tets * Joining copy files into a single target * Disabling the tests as they are currently broken
* fix race with external bot * remove frequencies for now * address comments
* Changing names to prefixes * Enabling test * Adding script to add missing dependency * Revert "Adding script to add missing dependency" This reverts commit f396678. * Reapply "Adding script to add missing dependency" This reverts commit d1d4e86. * Adding new script to download UWP version of VCLibs * Adding the ps1 script I forgot * Trying copying from VS * Removing installation of unexisting UWP packages * Using package manifest for vclibs * Fixing version * Removing install of VClibs in yml file * Putting version to 0 * Implementing TODO * Adding entry to bypass tests * Bypassing every individual test
…d in Transport package or nuget logic). See #5250 (reply in thread) (#5734)
* Enabling version info tests * Fixing typo
…update as Centralized Nuget Management for vcxproj (#6106) * Update the right logic on replacing packages * Rename misleading variable names in package replacement logic (#6107) * Initial plan * Rename misleading variable names to reflect package references Co-authored-by: yeelam-gordon <73506701+yeelam-gordon@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: yeelam-gordon <73506701+yeelam-gordon@users.noreply.github.com> * Fix partial package name matching in NuGet replacement regex (#6109) * Initial plan * Fix regex pattern to prevent partial package name matches Co-authored-by: yeelam-gordon <73506701+yeelam-gordon@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: yeelam-gordon <73506701+yeelam-gordon@users.noreply.github.com> * Consolidate duplicate package replacement logic for project files (#6110) * Initial plan * Consolidate duplicate package replacement logic for project files Co-authored-by: yeelam-gordon <73506701+yeelam-gordon@users.noreply.github.com> * Move string constants outside loop to avoid redundant allocations Co-authored-by: yeelam-gordon <73506701+yeelam-gordon@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: yeelam-gordon <73506701+yeelam-gordon@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
* Creating nuget directory if it does not exist * Using variable to reduce computations * Fixing original nuget.exe path and implementing recommended changes * Full path trick * Removing join-path * Adding back join path
* add package deployment progress bar * incorporate PR suggestions * remove label * incorporate suggestions * incorporate suggestions
…nSkim scanning (#6119) * Update WindowsAppSDK-CommonVariables.yml * Update WindowsAppSDK-Foundation-DevTest.yml * Update WindowsAppSDK-Foundation-Nightly.yml * Replace analyzeTargetGlob with variable reference * Update WindowsAppSDK-Foundation-PR.yml
…on/_git/WindowsAppSDKAggregator build 2.0.260106.1-experimental (#6124) [main] Update dependencies from microsoft/ProjectReunion/WindowsAppSDKAggregator
* docs(prompts): add comprehensive guidelines for Copilot prompt files * refactor(prompts): update incremental review detection logic and scripts * feat(tools): add Git worktree management scripts for parallel development * docs(instructions): add guidelines for creating Agent Skills for Copilot * docs(instructions): clarify AI agent terminology in Agent Skills guidelines * refactor(tools): migrate worktree scripts to GitHub skills structure * refactor(prompts): reorder workflow steps in PR summary generation * docs(instructions): update prompt guidelines for consistent terminology * refactor(tools): enhance worktree management scripts for better error handling * docs(worktree-manager): clarify cognitive load guidelines in SKILL.md * refactor(tools): remove unified entry point from worktree helper scripts * refactor(prompts): enhance GitHub MCP availability checks and fallback options * refactor(prompts): streamline PR review process and improve tool invocation * Update tools/git/Worktree-Guidelines.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…g it to the output path (#6128)
…lume? #5485 (#6104) Add PackageVolume APIs for parity+ with `Windows.Management.Deployment` PackageVolume additions: * IsAppxInstallSupported * IsOffline * static IsFeatureSupported() * static AddAsync() * static GetDefault() * GetAvailableSpaceAsync() * GetPackageVolumeByName() * GetPackageVolumeByPath() * RemoveAsync() * SetDefault() * SetOfflineAsync() * SetOnlineAsync() NOTE: `FindPackageVolumeBy...` are deprecated and will be removed in a future release. Use the equivalent `GetPackageVolumeBy...` methods, which are identical except for the name (per standard WinRT naming, Find=return list, Get=return 1 (or null)). See `specs\packagemanager\PackageManagement.md` and #5485 (comment) for more information. Also fixes a bug in `EnsurePackageSetReady*Async()` yielding progress values >1.0 closes #5485 https://task.ms/57784255
…on/_git/WindowsAppSDKAggregator build 2.0.260122.1-experimental (#6157) On relative base path root Microsoft.WindowsAppSDK.Base From Version 2.0.260106001-experimental -> To Version 2.0.260122001-experimental Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…ngsIdentifier; FileTypeIndex; Title; PickMultipleFoldersAsync; ShowOverwritePrompt (#6051) API Spec for - #6052 ## Adds properties: ### Title * Adds `Title` properties to `FileOpenPicker`, `FileSavePicker`, and `FolderPicker`, enabling custom dialog titles. Related: - #5879 ### SettingsIdentifier * Adds `SettingsIdentifier` properties to `FileOpenPicker`, `FileSavePicker`, and `FolderPicker`, enabling instance-specific picker state across sessions. Related: - #5847 - microsoft/microsoft-ui-xaml#10904 ### FileTypeIndex * Adds `FileTypeIndex` property to `FileOpenPicker` and `FileSavePicker`, allowing developers to set the default selected file type filter by index (0-based). Related: - #5975 ### Changes in FileSavePicker * Adds a new properties for `FileSavePicker`: `ShowOverwritePrompt`: `ShowOverwritePrompt` default to `true` and control whether the picker warns about overwriting when user picked an existing file via FileSavePicker. * Changing the default behavior - when the user picked a not-existing file via FileSavePicker, the picker will NOT create an empty file there - allowing developer to decide when to make this file. Related: - #5976 ## Adds method: ### FolderPicker.PickMultipleFoldersAsync * Adds `PickMultipleFoldersAsync` method to `FolderPicker`, enabling selection of multiple folders in a single operation. API definitions, documentation, and code samples have been updated to reflect this feature. Related: - #5848
…ndex; Title; PickMultipleFoldersAsync; ShowOverwritePrompt (#6052) Implementation for: - #6051 ## Adds properties: ### Title * Adds `Title` properties to `FileOpenPicker`, `FileSavePicker`, and `FolderPicker`, enabling custom dialog titles. Related: - #5879 ### SettingsIdentifier * Adds `SettingsIdentifier` properties to `FileOpenPicker`, `FileSavePicker`, and `FolderPicker`, enabling instance-specific picker state across sessions. Related: - #5847 - microsoft/microsoft-ui-xaml#10904 ### FileTypeIndex * Adds `FileTypeIndex` property to `FileOpenPicker` and `FileSavePicker`, allowing developers to set the default selected file type filter by index (0-based). Related: - #5975 ### Changes in FileSavePicker * Adds a new properties for `FileSavePicker`: `ShowOverwritePrompt`: `ShowOverwritePrompt` default to `true` and control whether the picker warns about overwriting when user picked an existing file via FileSavePicker. * Changing the default behavior - when the user picked a not-existing file via FileSavePicker, the picker will NOT create an empty file there - allowing developer to decide when to make this file. Related: - #5976 ## Adds method: ### FolderPicker.PickMultipleFoldersAsync * Adds `PickMultipleFoldersAsync` method to `FolderPicker`, enabling selection of multiple folders in a single operation. API definitions, documentation, and code samples have been updated to reflect this feature. Related: - #5848
Added implementation for PackageValidator APIs
…chment analysis (#6158) * Add GitHub MCP tools for handling issue images and attachments - Implemented `github_issue_images` tool to download images from GitHub issues and PRs. - Implemented `github_issue_attachments` tool to download and extract ZIP file attachments from GitHub issues. - Added test scripts for both tools to validate functionality. - Created necessary configuration files and server launch script for the MCP tools. - Updated documentation to include usage instructions for the new tools. * Remove model specification from prompt files for consistency * Add instructions for building MCP servers using TypeScript SDK * Update tools/mcp/github-artifacts/package.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update tools/mcp/github-artifacts/server.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: address active PR review comments - add README.md and simplify MCP instructions * chore(vscode): update .gitignore and add MCP configuration files --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…on/_git/WindowsAppSDKAggregator build 2.0.260122.2-experimental (#6159) On relative base path root Microsoft.WindowsAppSDK.Base From Version 2.0.260122001-experimental -> To Version 2.0.260122002-experimental Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* cp * comments * event name changes * event name changes * cleanup * cp * cp --------- Co-authored-by: Darshak Bhatti <dabhatti@micorsoft.com>
…ng (#6169) * feat(issue-triage): add scripts for area contacts and highlight scoring * feat(reporting): enhance scoring logic and add validation for repository input * feat(issue-triage): update scoring weights and remove external contributor logic * Update .github/skills/issue-triage-report/references/scoring-algorithm.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat(issue-triage): update labels and scoring thresholds for issue highlights * feat(contacts): update area contacts configuration and loading logic * Use generic Area Contacts in SKILL.md * docs(licensing): add licensing section to README --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Lauren Ciha <laurenciha@microsoft.com>
* Update dependencies from https://dev.azure.com/microsoft/LiftedIXP/_git/DCPP build 20260129.1 On relative base path root Microsoft.FrameworkUdk , Microsoft.ProjectReunion.InteractiveExperiences.TransportPackage From Version 2.0.0-experimental-27200.1845.251215-1020.5 -> To Version 2.0.0-experimental-27200.1852.260127-0700.1 Microsoft.WindowsAppSDK.InteractiveExperiences From Version 2.0.5-experimental -> To Version 2.0.6-experimental * Update dependencies from https://dev.azure.com/microsoft/LiftedIXP/_git/DCPP build 20260129.2 On relative base path root Microsoft.FrameworkUdk , Microsoft.ProjectReunion.InteractiveExperiences.TransportPackage From Version 2.0.0-experimental-27200.1845.251215-1020.5 -> To Version 2.0.0-preview-27200.1852.260127-0700.2 Microsoft.WindowsAppSDK.InteractiveExperiences From Version 2.0.5-experimental -> To Version 2.0.6-preview --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* fix dup warning with workaround * add condition make it only for arm64ec+ltcg --------- Co-authored-by: Qiutong Shen <qiutongshen@microsoft.com>
…to AppNotification tests (#6190) * protect experimental tests * update skip message to reference AddCameraPreview API * Fix WEX logging namespace in AppNotificationBuilderTests
…ts (#6179) * feat(triage): implement triage meeting preparation workflow and scripts * fix: address PR review comments - PowerShell best practices and docs - Add copyright headers to PowerShell scripts - Add Set-StrictMode -Version 2.0 and ErrorActionPreference - Fix null reference issues for author, milestone, and reaction counts - Add explicit exit 0 for successful execution - Add license field to SKILL.md frontmatter - Fix broken emoji in template-summary.md - Fix duplicate step/phase numbering in workflow-triage-prep.md * fix: move strict mode settings inside begin block StrictMode and ErrorActionPreference must be inside the begin block when using begin/process/end pipeline structure * fix: align workflow documentation schema with actual implementation Update workflow-triage-prep.md to match the actual JSON schema produced by Save-TriageState.ps1: - Replace noAreaIssues/closedIssues structure with flat 'issues' object - Remove non-existent fields: firstSeen, weeksPending, lastSuggestedAction, reviewPath - Add actual fields: generatedAt, issueCount, state, author, commentCount, reactionCount, labels, milestone - Update pseudocode references from previousState.allIssues to previousState.issues Addresses PR review comment about schema repetition/inconsistency. * Revert "fix: align workflow documentation schema with actual implementation" This reverts commit 47ad69d. * fix: remove redundant 'number' field from issue objects The issue number is already used as the dictionary key, so storing it again inside the value object is redundant. Removed from: - Save-TriageState.ps1 - Compare-TriageState.ps1 - workflow-triage-prep.md documentation schema Addresses PR review comment about information repetition. * feat(triage): enhance triage meeting prep with GitHub CLI scripts * fix: UTC timestamps and case-insensitive state comparison Addresses 5 review comments from copilot-pull-request-reviewer: Save-TriageState.ps1: - Fix triageDate and generatedAt to use ToUniversalTime() for proper UTC Compare-TriageState.ps1: - Fix state comparison to use case-insensitive (-ieq) since GitHub API returns uppercase OPEN/CLOSED - Fix summary output timestamp to use ToUniversalTime() for proper UTC * fix: Add ValidatePattern for Repository and use Write-Verbose for progress Addresses review comments from copilot-pull-request-reviewer: Get-TriageIssues.ps1 & Get-IssueDetails.ps1: - Add ValidatePattern to validate owner/repo format for Repository parameter - Prevents potential injection via malformed repository names All scripts: - Change progress Write-Host to Write-Verbose for automation support - Users can now control verbosity with -Verbose switch - Summary output Write-Host retained (user-facing display) Note: .WriteError() suggestion deferred as larger refactor. See Generated Files/prReview/6179/fixPlan/overview.md for details. * Add Get-RepositoryLabels.ps1 script to triage-meeting-prep skill - New script to fetch all label definitions from a GitHub repository - Supports filtering by label name pattern (e.g., 'area-*') - Three output formats: json, summary, and table - Color output: hex color codes displayed in their actual colors - Dark colors shown with light background for visibility - Updated SKILL.md with script documentation and examples --------- Co-authored-by: Lauren Ciha <laurenciha@microsoft.com>
* Add PowerShell task to manage artifactStatus variable Added a PowerShell task to edit the artifactStatus variable based on the job status. Updated the artifact name to use artifactStatus instead of Agent.JobStatus. * Update artifact suffix and add artifact status variable * Update artifact suffix to include status in CI config
Fix copy-paste error in IntelliSense XML where IsSupported documentation incorrectly referenced PushNotifications instead of AppNotifications. Changes: - Microsoft.Windows.PushNotifications -> Microsoft.Windows.AppNotifications - PushNotificationManager -> AppNotificationManager - 'push notifications' -> 'app notifications' Fixes #4504
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.