copy bftrees from the snapshot location to the save location#783
Merged
copy bftrees from the snapshot location to the save location#783
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates bf-tree index persistence so that when saving an on-disk bf-tree-based index, the generated snapshot files are copied from the bf-tree’s internal snapshot location to the save prefix location provided to save_with().
Changes:
- Change bf-tree provider
snapshot()helpers to return the snapshotPathBuf. - Update
BfTreeProvider::save_with()to copy vector/neighbor/(quant).bftreesnapshot files to the target prefix paths when they differ.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| diskann-providers/src/model/graph/provider/async_/bf_tree/vector_provider.rs | Make snapshot() return the underlying bf-tree snapshot path (PathBuf). |
| diskann-providers/src/model/graph/provider/async_/bf_tree/quant_vector_provider.rs | Make snapshot() return the underlying bf-tree snapshot path (PathBuf). |
| diskann-providers/src/model/graph/provider/async_/bf_tree/neighbor_provider.rs | Make snapshot() return the underlying bf-tree snapshot path (PathBuf). |
| diskann-providers/src/model/graph/provider/async_/bf_tree/provider.rs | Copy .bftree snapshot outputs to the save prefix paths during save_with(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
diskann-providers/src/model/graph/provider/async_/bf_tree/provider.rs
Outdated
Show resolved
Hide resolved
diskann-providers/src/model/graph/provider/async_/bf_tree/provider.rs
Outdated
Show resolved
Hide resolved
diskann-providers/src/model/graph/provider/async_/bf_tree/provider.rs
Outdated
Show resolved
Hide resolved
diskann-providers/src/model/graph/provider/async_/bf_tree/provider.rs
Outdated
Show resolved
Hide resolved
diskann-providers/src/model/graph/provider/async_/bf_tree/provider.rs
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
==========================================
- Coverage 89.00% 89.00% -0.01%
==========================================
Files 428 428
Lines 78417 78417
==========================================
- Hits 69795 69793 -2
- Misses 8622 8624 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
metajack
approved these changes
Feb 17, 2026
hildebrandmw
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small PR that makes sure that we copy on-disk bftree index files from the snapshot() location to the location as specified when saving the bf-tree based index.