Skip to content

copy bftrees from the snapshot location to the save location#783

Merged
backurs merged 4 commits intomainfrom
arturs/copy_bftrees
Feb 18, 2026
Merged

copy bftrees from the snapshot location to the save location#783
backurs merged 4 commits intomainfrom
arturs/copy_bftrees

Conversation

@backurs
Copy link
Contributor

@backurs backurs commented Feb 16, 2026

This is a small PR that makes sure that we copy on-disk bftree index files from the snapshot() location to the location as specified when saving the bf-tree based index.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates bf-tree index persistence so that when saving an on-disk bf-tree-based index, the generated snapshot files are copied from the bf-tree’s internal snapshot location to the save prefix location provided to save_with().

Changes:

  • Change bf-tree provider snapshot() helpers to return the snapshot PathBuf.
  • Update BfTreeProvider::save_with() to copy vector/neighbor/(quant) .bftree snapshot files to the target prefix paths when they differ.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
diskann-providers/src/model/graph/provider/async_/bf_tree/vector_provider.rs Make snapshot() return the underlying bf-tree snapshot path (PathBuf).
diskann-providers/src/model/graph/provider/async_/bf_tree/quant_vector_provider.rs Make snapshot() return the underlying bf-tree snapshot path (PathBuf).
diskann-providers/src/model/graph/provider/async_/bf_tree/neighbor_provider.rs Make snapshot() return the underlying bf-tree snapshot path (PathBuf).
diskann-providers/src/model/graph/provider/async_/bf_tree/provider.rs Copy .bftree snapshot outputs to the save prefix paths during save_with().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.00%. Comparing base (7cd231a) to head (665937c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
- Coverage   89.00%   89.00%   -0.01%     
==========================================
  Files         428      428              
  Lines       78417    78417              
==========================================
- Hits        69795    69793       -2     
- Misses       8622     8624       +2     
Flag Coverage Δ
miri 89.00% <ø> (-0.01%) ⬇️
unittests 89.00% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@backurs backurs merged commit e5c83f5 into main Feb 18, 2026
22 checks passed
@backurs backurs deleted the arturs/copy_bftrees branch February 18, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments