Skip to content

Comments

[NFC][CMAKE] Fix warning on MacOS build#8166

Open
Keenuts wants to merge 2 commits intomicrosoft:mainfrom
Keenuts:cmake-fixes-macos
Open

[NFC][CMAKE] Fix warning on MacOS build#8166
Keenuts wants to merge 2 commits intomicrosoft:mainfrom
Keenuts:cmake-fixes-macos

Conversation

@Keenuts
Copy link
Collaborator

@Keenuts Keenuts commented Feb 18, 2026

This commit fixes 2 warnings showing on when building on MacOS:

  • CMP0135: setting which policy is applied on download freshness check
  • METAL_IRCONVERTER case not matching the FindPackage filename.

Cmake shows a warning because the FindPackage file is using
the camel-case format while the variable prefix is set to the
all-uppercase variant.
Copy link
Collaborator

@s-perron s-perron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll abstain. I cannot check this myself, and I don't know the consequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

2 participants